[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] make org-clock-time% respect org-effort-durations and re
From: |
Kyle Meyer |
Subject: |
Re: [O] [PATCH] make org-clock-time% respect org-effort-durations and related |
Date: |
Sun, 25 Oct 2015 13:23:19 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Hello,
Jan Malakhovski <address@hidden> writes:
> Hi.
>
> The first patch here is a must, because it fixes a bug I stumble upoon
> daily. Middle two are just to make the names consistent. While doing
> all those changes I read quite a lot of code and the last patch adds a
> FIXME for a particularly ugly place I'm not sure how to fix (I think
> don't ever consciously use that code path and I'm not sure what it
> supposed to do).
Thanks for these patches, as well as the other series you sent [1]. I
haven't looked at the content in detail, but based on the diffstats,
these changes are touching enough lines to require copyright assignment
[2]. Also, please include a ChangeLog entry in the commit message [3].
Thanks again.
[1] http://thread.gmane.org/gmane.emacs.orgmode/102168
[2] http://orgmode.org/worg/org-contribute.html#orgheadline2
[3] http://orgmode.org/worg/org-contribute.html#orgheadline6
--
Kyle