Re: [O] re-search-forward hang in org-link-search

[Nicolas Goaziou]

Pip Cet <address@hidden> writes:

> Of course, here we go. Please let me know if there's anything wrong
> with it still. (I don't think gmail copy-and-paste preserves tabs, so
> this is sent as an attachment. Is that okay, for future reference?)
>
> It would be great if README_contribute could be updated no longer to
> refer to ChangeLog files, and instead refer to the Emacs CONTRIBUTE
> file (it would also be great if the special git commit messages could
> be generated as easily as C-x 4 a does for ChangeLog entries. What do
> people use for that?); I've attached a patch to change that as well,
> but I'm not sure whether it's still properly a TINYCHANGE. Again, it
> would be great if you could let me know if there's anything wrong with
> it so I can avoid making the same mistake for future contributions.

Thanks for your patches. They look good. I applied them with very minor
tweaks, explained below.

> Subject: [PATCH 1/2] org.el: fix recursive regular expression backtracking

"Fix" needs to be capitalized.

>
>       * org.el (org-link-search): Avoid recursive regexp
>       backtracking behaviour when following search links.

Emacs uses American spelling: "behavior".

> Subject: [PATCH 2/2]  Remove references to ChangeLog.

No full stop at the end of the commit summary.

>       * README_contribute: remove references to ChangeLog.  Instead,

"Remove"

> +   - Org-mode no longer uses ChangeLog entries to document

We try to change "Org-mode" into "Org mode" whenever we can.

> +     changes. Instead, special commit messages are used, as

Sentences are separated with two spaces.


Regards,