Re: [O] current head croaks on export since commit "Backport commit 3a5f751 from Emacs master branch"

[Kyle Meyer]

Robert Klein <address@hidden> wrote:
> Hi,
>
> when I export a file with current org main I get the following error
> (git-bisect-identified commit below):
[...]
>  git bisect bad
> ef9637030456b153fd834f4c9202a9264d5ef18d is the first bad commit
> commit ef9637030456b153fd834f4c9202a9264d5ef18d
> Author: Stefan Monnier <address@hidden>
> Date:   Sat Aug 8 19:41:57 2015 -0400
>
>     Backport commit 3a5f751 from Emacs master branch

Thank you for the report.

> If the changes in the commit are Ok, there should perhaps be a check in
> org-check-agenda-file:
>
> (defun org-check-agenda-file (file)
>   "Make sure FILE exists.  If not, ask user what to do."
>   (when (not (string-p file))
>       do something else...

Based on the backtrace, I think this is another instance like 11e8749
("org-clock: Fix org-agenda-prepare-buffers call", 2015-08-09), where
org-agenda-prepare-buffers was being called with '(nil)' for the list of
files.

The backport changed a '(while (setq VAR (pop LIST)))' to
'(dolist (VAR LIST))', which exposes this, but '(nil)' should not be
passed as a list of files in the first place.

I'll have a closer look.

--
Kyle