[O] Problem with org-clock-persistence-insinuate in org-plus-contrib

[T.F. Torrey]

Hello,

I am trying to use the latest version of the org-plus-contrib from the
org Elpa repository (and using emacs-snapshot in Ubuntu 12-04), but I
get a weird error.  My first clue was this error:

#+BEGIN_QUOTE
Warning (initialization): An error occurred while loading 
`/home/tftorrey/.emacs.d/init.el':

Symbol's function definition is void: org-find-library-dir

To ensure normal operation, you should investigate and remove the
cause of the error in your initialization file.  Start Emacs with
the `--debug-init' option to view a complete error backtrace.
#+END_QUOTE

Starting Emacs with emacs --debug-init produces this backtrace:

#+BEGIN_QUOTE
Debugger entered--Lisp error: (void-function org-find-library-dir)
  (org-find-library-dir "org")
  (file-name-directory (org-find-library-dir "org"))
  (expand-file-name "../contrib" (file-name-directory (org-find-library-dir 
"org")))
  (file-name-as-directory (expand-file-name "../contrib" (file-name-directory 
(org-find-library-dir "org"))))
  (expand-file-name "scripts" (file-name-as-directory (expand-file-name 
"../contrib" (file-name-directory (org-find-library-dir "org")))))
  (file-name-as-directory (expand-file-name "scripts" (file-name-as-directory 
(expand-file-name "../contrib" (file-name-directory (org-find-library-dir 
"org"))))))
  (expand-file-name "ditaa.jar" (file-name-as-directory (expand-file-name 
"scripts" (file-name-as-directory (expand-file-name "../contrib" 
(file-name-directory (org-find-library-dir "org")))))))
  eval((expand-file-name "ditaa.jar" (file-name-as-directory (expand-file-name 
"scripts" (file-name-as-directory (expand-file-name "../contrib" 
(file-name-directory (org-find-library-dir "org"))))))))
  custom-initialize-reset(org-ditaa-jar-path (expand-file-name "ditaa.jar" 
(file-name-as-directory (expand-file-name "scripts" (file-name-as-directory 
(expand-file-name "../contrib" (file-name-directory (org-find-library-dir 
"org"))))))))
  custom-declare-variable(org-ditaa-jar-path (expand-file-name "ditaa.jar" 
(file-name-as-directory (expand-file-name "scripts" (file-name-as-directory 
(expand-file-name "../contrib" (file-name-directory (org-find-library-dir 
"org"))))))) 
("/home/tftorrey/.emacs.d/elpa/org-plus-contrib-20121022/org-exp-blocks.elc" . 
5960) :group org-babel :type string)
  require(org-exp-blocks)
  
byte-code("\300\301!\210\300\302!\210\300\303!\210\300\304!\210\300\305!\210\300\306!\207"
 [require org org-macs org-agenda org-exp-blocks ob-exp org-src] 2)
  require(org-exp)
  require(org-clock)
  org-clock-persistence-insinuate()
  eval-buffer(#<buffer  *load*-724658> nil 
"/home/tftorrey/.emacs.d/emacs-tftorrey.el" nil t)  ; Reading at buffer 
position 42296
  load-with-code-conversion("/home/tftorrey/.emacs.d/emacs-tftorrey.el" 
"/home/tftorrey/.emacs.d/emacs-tftorrey.el" nil nil)
  load("/home/tftorrey/.emacs.d/emacs-tftorrey.el" nil nil t)
  load-file("/home/tftorrey/.emacs.d/emacs-tftorrey.el")
  org-babel-load-file("/home/tftorrey/.emacs.d/emacs-tftorrey.org")
  eval-buffer(#<buffer  *load*> nil "/home/tftorrey/.emacs.d/init.el" nil t)  ; 
Reading at buffer position 379
  load-with-code-conversion("/home/tftorrey/.emacs.d/init.el" 
"/home/tftorrey/.emacs.d/init.el" t t)
  load("/home/tftorrey/.emacs.d/init" t t)
  #[0 "\205\262        \306=\203\307\310Q\202;       
\311=\204\307\312Q\202;\313\307\314\315#\203*\316\202;\313\307\314\317#\203:\320\nB\321\202;\316\322\323\322\211#\210\322=\203a\324\325\326\307\327Q!\"\323\322\211#\210\322=\203`
\210\203\243\330!\331\232\203\243\332!\211\333P\334!\203}\211\202\210\334!\203\207
\202\210\314\262
\203\241\335\"\203\237\336\337#\210\340\341!\210\266\f?\205\260\314\323\342\322\211#)\262\207"
 [init-file-user system-type delayed-warnings-list user-init-file 
inhibit-default-init inhibit-startup-screen ms-dos "~" "/_emacs" windows-nt 
"/.emacs" directory-files nil "^\\.emacs\\(\\.elc?\\)?$" "~/.emacs" 
"^_emacs\\(\\.elc?\\)?$" (initialization "`_emacs' init file is deprecated, 
please use `.emacs'") "~/_emacs" t load expand-file-name "init" 
file-name-as-directory "/.emacs.d" file-name-extension "elc" 
file-name-sans-extension ".el" file-exists-p file-newer-than-file-p message 
"Warning: %s is newer than %s" sit-for 1 "default"] 7 "\n\n(fn)"]()
  command-line()
  normal-top-level()
#+END_QUOTE

If I comment out (org-clock-persistence-insinuate) in my init files,
Emacs starts without error.

What's extra weird is that if I then uncomment
(org-clock-persistence-insinuate) and restart Emacs, it starts without
error -- once.  After that, it produces the original error again.

I don't understand that backtrace very well, but it looks like something
is hardcoded to look in a contrib subdirectory for the contrib files and
can't find them when they are moved to the root of the package
directory.

Finally, I haven't taken the time to debug it fully, but trying to
prepare this bug report using the org-plus-contrib package also failed,
with this error that looks related:

#+BEGIN_QUOTE
Calling org-submit-bug-report

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  file-name-directory(nil)
  (expand-file-name "../contrib" (file-name-directory (or load-file-name 
buffer-file-name)))
  (file-name-as-directory (expand-file-name "../contrib" (file-name-directory 
(or load-file-name buffer-file-name))))
  (expand-file-name "scripts" (file-name-as-directory (expand-file-name 
"../contrib" (file-name-directory (or load-file-name buffer-file-name)))))
  (file-name-as-directory (expand-file-name "scripts" (file-name-as-directory 
(expand-file-name "../contrib" (file-name-directory (or load-file-name 
buffer-file-name))))))
  (expand-file-name "ditaa.jar" (file-name-as-directory (expand-file-name 
"scripts" (file-name-as-directory (expand-file-name "../contrib" 
(file-name-directory (or load-file-name buffer-file-name)))))))
  eval((expand-file-name "ditaa.jar" (file-name-as-directory (expand-file-name 
"scripts" (file-name-as-directory (expand-file-name "../contrib" 
(file-name-directory (or load-file-name buffer-file-name))))))))
  #[(v) 
"\302!\205;\303\304\305!\"\205;J\203\303\306\305!\"\2046\307N\205;\310N\205;address@hidden;
     B\211\207" [v list boundp string-match "\\`\\(org-\\|outline-\\)" 
symbol-name "\\(-hook\\|-function\\)\\'" custom-type standard-value eval] 
4](org-ditaa-jar-path)
  mapatoms(#[(v) 
"\302!\205;\303\304\305!\"\205;J\203\303\306\305!\"\2046\307N\205;\310N\205;address@hidden;
    B\211\207" [v list boundp string-match "\\`\\(org-\\|outline-\\)" 
symbol-name "\\(-hook\\|-function\\)\\'" custom-type standard-value eval] 4])
  org-submit-bug-report()
  call-interactively(org-submit-bug-report record nil)
  command-execute(org-submit-bug-report record)
  execute-extended-command(nil "org-submit-bug-report")
  call-interactively(execute-extended-command nil nil)
#+END_QUOTE

Best regards,
Terry
-- 
T.F. Torrey