[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] Tangling is broken in git master
From: |
Bastien |
Subject: |
Re: [O] Tangling is broken in git master |
Date: |
Mon, 13 Aug 2012 21:00:04 +0200 |
User-agent: |
Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) |
Hi Nick,
Nick Dokos <address@hidden> writes:
> I'd suggest that that can be a source of bugs that would be
> avoided with a compatibility macro.
`org-labels' is an alias for `cl-labels' (when available) or `labels'.
There is no need for a compatibility macro here, as the current code
is compatible with both Emacs 23 and Emacs 24 -- and hopefully later
versions of Emacs.
The question is rather whether we want to be very strict and replace
as much cl-* constructs as possible.
Nicolas shown a way to let-bind functions recursively (which is simple
and neat, by the way), so yes, I'd favor replacing org-labels in this
case. Especially because the cl-labels and labels macros do not work
exactly the same way.
See labels' docstring:
...
Like `cl-labels' except that the lexical scoping is handled via `lexical-let'
rather than relying on `lexical-binding'.
> But maybe the compatibility macro would be a bigger problem - I don't
> know for sure. In particular, the file would need a periodic cleanup to
> get rid of old cruft, but if it's a once-a-year-or-two occurrence, that
> might not be too bad.
Always good to know there are many people we can rely on to clean the
old cruft :)
--
Bastien
- Re: [O] Tangling is broken in git master, (continued)
- Re: [O] Tangling is broken in git master, Bastien, 2012/08/13
- Re: [O] Tangling is broken in git master, Eric Schulte, 2012/08/13
- Re: [O] Tangling is broken in git master, Bastien, 2012/08/13
- Re: [O] Tangling is broken in git master, Eric Schulte, 2012/08/13
- Re: [O] Tangling is broken in git master, Bastien, 2012/08/13
- Re: [O] Tangling is broken in git master, Nicolas Goaziou, 2012/08/13
- Re: [O] Tangling is broken in git master, Bastien, 2012/08/13
- Re: [O] Tangling is broken in git master, Nick Dokos, 2012/08/13
- Re: [O] Tangling is broken in git master, Bastien, 2012/08/13
- Re: [O] Tangling is broken in git master, Nick Dokos, 2012/08/13
- Re: [O] Tangling is broken in git master,
Bastien <=