emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 82e50a23fea: cperl-mode.el: Don't use obsolete `special-display-p


From: Stefan Monnier
Subject: master 82e50a23fea: cperl-mode.el: Don't use obsolete `special-display-popup-frame`
Date: Fri, 2 Feb 2024 18:59:33 -0500 (EST)

branch: master
commit 82e50a23fea8bc435bfae8390008702aa7d74bda
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    cperl-mode.el: Don't use obsolete `special-display-popup-frame`
    
    * lisp/progmodes/cperl-mode.el (cperl-info-on-command): Simplify,
    to let `pop-to-buffer` decide whether to create a new frame or not,
    so it can be controlled by `display-buffer-alist`.
---
 lisp/progmodes/cperl-mode.el | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el
index bfc1742610c..758a6e17f72 100644
--- a/lisp/progmodes/cperl-mode.el
+++ b/lisp/progmodes/cperl-mode.el
@@ -6612,14 +6612,13 @@ and \"Whitesmith\"."
             read))))
 
   (let ((cmd-desc (concat "^" (regexp-quote command) "[^a-zA-Z_0-9]")) ; 
"tr///"
-       pos isvar height iniheight frheight buf win fr1 fr2 iniwin not-loner
+       pos isvar height iniheight frheight buf win iniwin not-loner
        max-height char-height buf-list)
     (if (string-match "^-[a-zA-Z]$" command)
        (setq cmd-desc "^-X[ \t\n]"))
     (setq isvar (string-match "^[$@%]" command)
          buf (cperl-info-buffer isvar)
-         iniwin (selected-window)
-         fr1 (window-frame iniwin))
+         iniwin (selected-window))
     (set-buffer buf)
     (goto-char (point-min))
     (or isvar
@@ -6640,11 +6639,7 @@ and \"Whitesmith\"."
          (or (not win)
              (eq (window-buffer win) buf)
              (set-window-buffer win buf))
-         (and win (setq fr2 (window-frame win)))
-         (if (or (not fr2) (eq fr1 fr2))
-             (pop-to-buffer buf)
-           (special-display-popup-frame buf) ; Make it visible
-           (select-window win))
+         (pop-to-buffer buf)
          (goto-char pos)               ; Needed (?!).
          ;; Resize
          (setq iniheight (window-height)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]