[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
master f13c4f1562a: ; cperl-mode-tests.el: Avoid using skip-when
From: |
Harald Jörg |
Subject: |
master f13c4f1562a: ; cperl-mode-tests.el: Avoid using skip-when |
Date: |
Fri, 29 Sep 2023 10:48:28 -0400 (EDT) |
branch: master
commit f13c4f1562a99551920755f40a95084827920d2a
Author: Harald Jörg <haj@posteo.de>
Commit: Harald Jörg <haj@posteo.de>
; cperl-mode-tests.el: Avoid using skip-when
* test/lisp/progmodes/cperl-mode-tests.el: Add a hint to the
commentary that the tests are intended to run on older Emacsen.
(cperl-test-bug-10483): Replace skip-when by skip-unless followed
by a negation.
(cperl-test-bug-37127): Replace skip-when by skip-unless followed
by a negation.
---
test/lisp/progmodes/cperl-mode-tests.el | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/test/lisp/progmodes/cperl-mode-tests.el
b/test/lisp/progmodes/cperl-mode-tests.el
index 87d8ffa2d8d..a9bd803c815 100644
--- a/test/lisp/progmodes/cperl-mode-tests.el
+++ b/test/lisp/progmodes/cperl-mode-tests.el
@@ -25,6 +25,10 @@
;;; Commentary:
;; This is a collection of tests for CPerl-mode.
+;; The maintainer would like to use this test file with cperl-mode.el
+;; also in older Emacs versions (currently: Emacs 26.1): Please don't
+;; use Emacs features which are not available in that version (unless
+;; they're already used in existing tests).
;;; Code:
@@ -892,8 +896,8 @@ without a statement terminator on the same line does not
loop
forever. The test starts an asynchronous Emacs batch process
under timeout control."
:tags '(:expensive-test)
- (skip-when (getenv "EMACS_HYDRA_CI")) ; FIXME times out
- (skip-when (< emacs-major-version 28)) ; times out in older Emacsen
+ (skip-unless (not (getenv "EMACS_HYDRA_CI"))) ; FIXME times out
+ (skip-unless (not (< emacs-major-version 28))) ; times out in older Emacsen
(skip-unless (eq cperl-test-mode #'cperl-mode))
(let* ((emacs (concat invocation-directory invocation-name))
(test-function 'cperl-test--run-bug-10483)
@@ -1242,7 +1246,7 @@ however, must not happen when the keyword occurs in a
variable
\"$else\" or \"$continue\"."
(skip-unless (eq cperl-test-mode #'cperl-mode))
;; `self-insert-command' takes a second argument only since Emacs 27
- (skip-when (< emacs-major-version 27))
+ (skip-unless (not (< emacs-major-version 27)))
(with-temp-buffer
(setq cperl-electric-keywords t)
(cperl-mode)
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- master f13c4f1562a: ; cperl-mode-tests.el: Avoid using skip-when,
Harald Jörg <=