emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

emacs-29 6fe11b88ed0: Avoid using --display in emacsclient to reuse fram


From: Eli Zaretskii
Subject: emacs-29 6fe11b88ed0: Avoid using --display in emacsclient to reuse frames on PGTK
Date: Fri, 15 Sep 2023 07:33:53 -0400 (EDT)

branch: emacs-29
commit 6fe11b88ed044f08680a174ce1b7677b1a5d9be1
Author: Davide Masserut <dm@mssdvd.com>
Commit: Eli Zaretskii <eliz@gnu.org>

    Avoid using --display in emacsclient to reuse frames on PGTK
    
    Using hard-coded display values can cause PGTK graphical frames to
    open using the wrong backend or not open at all.
    * Makefile.in (install-etc): Use --reuse-frame instead of
    --display=$DISPLAY.  (Bug#65509)
---
 Makefile.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Makefile.in b/Makefile.in
index f5fda0eb61a..0ab34c8be6a 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -830,6 +830,9 @@ EMACS_ICON=emacs
 ifeq (${USE_STARTUP_NOTIFICATION},no)
 USE_STARTUP_NOTIFICATION_SED_CMD=-e "/^StartupNotify=true$$/d"
 endif
+ifeq ($(HAVE_PGTK),yes)
+USE_WAYLAND_DISPLAY_SED_CMD=-e "s/display=[^ ]*/reuse-frame/"
+endif
 install-etc:
        umask 022; ${MKDIR_P} "$(DESTDIR)${desktopdir}"
        tmp=etc/emacs.tmpdesktop; rm -f $${tmp}; \
@@ -844,6 +847,7 @@ install-etc:
        sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \
          -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \
          $(USE_STARTUP_NOTIFICATION_SED_CMD) \
+         $(USE_WAYLAND_DISPLAY_SED_CMD) \
          ${srcdir}/etc/emacsclient.desktop > $${tmp}; \
        ${INSTALL_DATA} $${tmp} 
"$(DESTDIR)${desktopdir}/$${client_name}.desktop"; \
        rm -f $${tmp}
@@ -857,6 +861,7 @@ install-etc:
        client_name=`echo emacsclient | sed '$(TRANSFORM)'`${EXEEXT}; \
        sed -e "/^Exec=/ s|emacsclient|${bindir}/$${client_name}|" \
          -e "/^Icon=emacs/ s/emacs/${EMACS_NAME}/" \
+         $(USE_WAYLAND_DISPLAY_SED_CMD) \
          ${srcdir}/etc/emacsclient-mail.desktop > $${tmp}; \
        ${INSTALL_DATA} $${tmp} 
"$(DESTDIR)${desktopdir}/$${client_name}-mail.desktop"; \
        rm -f $${tmp}



reply via email to

[Prev in Thread] Current Thread [Next in Thread]