emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 3f8db3bbe5e 1/8: image-dired: Fix gallery directory permissions


From: Stefan Kangas
Subject: master 3f8db3bbe5e 1/8: image-dired: Fix gallery directory permissions
Date: Sat, 5 Aug 2023 12:00:11 -0400 (EDT)

branch: master
commit 3f8db3bbe5ec8083a69e0eee54a06addd72131d6
Author: Stefan Kangas <stefankangas@gmail.com>
Commit: Stefan Kangas <stefankangas@gmail.com>

    image-dired: Fix gallery directory permissions
    
    * lisp/image/image-dired.el (image-dired-gallery-generate): Set
    umask to 077 before creating gallery directory.
---
 lisp/image/image-dired.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el
index 33beb5b3e49..9a92cae8ad5 100644
--- a/lisp/image/image-dired.el
+++ b/lisp/image/image-dired.el
@@ -1905,8 +1905,8 @@ when using per-directory thumbnail file storage"))
     (if (file-exists-p image-dired-gallery-dir)
         (if (not (file-directory-p image-dired-gallery-dir))
             (error "Variable image-dired-gallery-dir is not a directory"))
-      ;; FIXME: Should we set umask to 077 here, as we do for thumbnails?
-      (make-directory image-dired-gallery-dir))
+      (with-file-modes #o700
+        (make-directory image-dired-gallery-dir)))
     ;; Open index file
     (with-temp-file index-file
       (if (file-exists-p index-file)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]