emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

emacs-29 2ac8c4bbd6: (eglot-completion-at-point): Return correct values


From: Dmitry Gutov
Subject: emacs-29 2ac8c4bbd6: (eglot-completion-at-point): Return correct values in :company-kind
Date: Mon, 6 Feb 2023 17:28:44 -0500 (EST)

branch: emacs-29
commit 2ac8c4bbd6f47751a68b0230310f6fddd7da8de5
Author: Dmitry Gutov <dgutov@yandex.ru>
Commit: Dmitry Gutov <dgutov@yandex.ru>

    (eglot-completion-at-point): Return correct values in :company-kind
    
    * lisp/progmodes/eglot.el (eglot-completion-at-point): Return the
    correct values in :company-kind for "EnumMember" and "TypeParameter".
    The convention is to use kebab case rather than plain downcasing.
    Reported in https://github.com/company-mode/company-mode/issues/1370.
---
 lisp/progmodes/eglot.el | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 3fc1d68422..c906890c94 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -2873,7 +2873,10 @@ for which LSP on-type-formatting should be requested."
          (when-let* ((lsp-item (get-text-property 0 'eglot--lsp-item proxy))
                      (kind (alist-get (plist-get lsp-item :kind)
                                       eglot--kind-names)))
-           (intern (downcase kind))))
+           (pcase kind
+             ("EnumMember" 'enum-member)
+             ("TypeParameter" 'type-parameter)
+             (_ (intern (downcase kind))))))
        :company-deprecated
        (lambda (proxy)
          (when-let ((lsp-item (get-text-property 0 'eglot--lsp-item proxy)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]