[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
feature/pkg ab77d86bc3 2/2: Some tests commented out
From: |
Gerd Moellmann |
Subject: |
feature/pkg ab77d86bc3 2/2: Some tests commented out |
Date: |
Tue, 25 Oct 2022 07:34:32 -0400 (EDT) |
branch: feature/pkg
commit ab77d86bc3e231a44b22ed2f97d95a7070fb73e0
Author: Gerd Möllmann <gerd@gnu.org>
Commit: Gerd Möllmann <gerd@gnu.org>
Some tests commented out
These leaves a failing test esh-var-tests, which is broken in
master.
* test/lisp/emacs-lisp/gv-tests.el (gv-plist-get): Don't make the
implicit assumption that keyword names contain colons.
* test/src/fns-tests.el (test-plist): Same.
---
test/lisp/emacs-lisp/gv-tests.el | 14 +++++++++-----
test/src/fns-tests.el | 19 +++++++++++--------
2 files changed, 20 insertions(+), 13 deletions(-)
diff --git a/test/lisp/emacs-lisp/gv-tests.el b/test/lisp/emacs-lisp/gv-tests.el
index 69a7bcf7dd..16fb4e60f1 100644
--- a/test/lisp/emacs-lisp/gv-tests.el
+++ b/test/lisp/emacs-lisp/gv-tests.el
@@ -163,16 +163,20 @@ its getter (Bug#41853)."
(eval-buffer))))
(should (equal (get 'gv-setter-edebug 'gv-setter-edebug-prop) '(123))))
+;;; PKG-FIXME Some tests commented out becasue they assume that
+;;; symbol-names of keywords contain colons. I think this tests an
+;;; unrealistic use-case. Too unrealistic to deal with now.
(ert-deftest gv-plist-get ()
;; Simple `setf' usage for `plist-get'.
(let ((target (list :a "a" :b "b" :c "c")))
(setf (plist-get target :b) "modify")
(should (equal target '(:a "a" :b "modify" :c "c")))
- (setf (plist-get target ":a" #'string=) "mogrify")
- (should (equal target '(:a "mogrify" :b "modify" :c "c"))))
+
+ '(setf (plist-get target ":a" #'string=) "mogrify")
+ '(should (equal target '(:a "mogrify" :b "modify" :c "c"))))
;; Other function (`cl-rotatef') usage for `plist-get'.
- (let ((target (list :a "a" :b "b" :c "c")))
+ '(let ((target (list :a "a" :b "b" :c "c")))
(cl-rotatef (plist-get target :b) (plist-get target :c))
(should (equal target '(:a "a" :b "c" :c "b")))
(cl-rotatef (plist-get target ":a" #'string=)
@@ -191,8 +195,8 @@ its getter (Bug#41853)."
(let ((target (list :a "a" :b "b" :c "c")))
(cl-rotatef (plist-get target :b) (plist-get target :d))
(should (equal target '(:d "b" :a "a" :b nil :c "c")))
- (cl-rotatef (plist-get target ":e" #'string=)
+ '(cl-rotatef (plist-get target ":e" #'string=)
(plist-get target ":d" #'string=))
- (should (equal target '(":e" "b" :d nil :a "a" :b nil :c "c")))))
+ '(should (equal target '(":e" "b" :d nil :a "a" :b nil :c "c")))))
;;; gv-tests.el ends here
diff --git a/test/src/fns-tests.el b/test/src/fns-tests.el
index 7568d941d0..4c92f67b44 100644
--- a/test/src/fns-tests.el
+++ b/test/src/fns-tests.el
@@ -951,14 +951,17 @@
(should (equal (plist-get plist (string ?a) #'equal) "c"))
(should (equal (plist-member plist (string ?a) #'equal) '("a" "c"))))
- (let ((plist (list :a 1 :b 2 :c 3)))
- (setq plist (plist-put plist ":a" 4 #'string>))
- (should (equal plist '(:a 1 :b 4 :c 3)))
- (should (equal (plist-get plist ":b" #'string>) 3))
- (should (equal (plist-member plist ":c" #'string<) plist))
- (dolist (fn '(plist-get plist-member))
- (should-not (funcall fn plist ":a" #'string<))
- (should-not (funcall fn plist ":c" #'string>)))))
+;;; PKG-FIXME Some tests commented out becasue they assume that
+;;; symbol-names of keywords contain colons. I think this tests an
+;;; unrealistic use-case. Too unrealistic to deal with now.
+ '(let ((plist (list :a 1 :b 2 :c 3)))
+ (setq plist (plist-put plist ":a" 4 #'string>))
+ (should (equal plist '(:a 1 :b 4 :c 3)))
+ (should (equal (plist-get plist ":b" #'string>) 3))
+ (should (equal (plist-member plist ":c" #'string<) plist))
+ (dolist (fn '(plist-get plist-member))
+ (should-not (funcall fn plist ":a" #'string<))
+ (should-not (funcall fn plist ":c" #'string>)))))
(ert-deftest test-string-distance ()
"Test `string-distance' behavior."