emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

feature/eglot2emacs cb562118cb 047/120: Don't strip invisible text when


From: João Távora
Subject: feature/eglot2emacs cb562118cb 047/120: Don't strip invisible text when formatting hover string
Date: Thu, 20 Oct 2022 07:16:51 -0400 (EDT)

branch: feature/eglot2emacs
commit cb562118cb14d8bb71140a07232107d83bbbf6d9
Author: Augusto Stoffel <arstoffel@gmail.com>
Commit: GitHub <noreply@github.com>

    Don't strip invisible text when formatting hover string
    
    This was introduced in https://github.com/joaotavora/eglot/issues/482 due 
to a bad interaction with a specific
    server.  But this solution makes hyperlinks in Eldoc buffers
    unclickable, because the markdown-mode function that visits a link
    relies on the invisible text.
    
    Per https://github.com/joaotavora/eglot/issues/866
    
    * eglot.el (eglot--format-markup): Use buffer-string instead of
    filter-buffer-substring
    
    GitHub-reference: fix https://github.com/joaotavora/eglot/issues/865
---
 lisp/progmodes/eglot.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 7bff005973..b84e1449d7 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -1436,7 +1436,7 @@ Doubles as an indicator of snippet support."
            (message-log-max nil))
         (ignore-errors (delay-mode-hooks (funcall mode))))
       (font-lock-ensure)
-      (string-trim (filter-buffer-substring (point-min) (point-max))))))
+      (string-trim (buffer-string)))))
 
 (define-obsolete-variable-alias 'eglot-ignored-server-capabilites
   'eglot-ignored-server-capabilities "1.8")



reply via email to

[Prev in Thread] Current Thread [Next in Thread]