emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

feature/eglot2emacs ef0da9414e 060/120: Make eglot--plist-keys a simple


From: João Távora
Subject: feature/eglot2emacs ef0da9414e 060/120: Make eglot--plist-keys a simple (non-map.el) helper again
Date: Thu, 20 Oct 2022 07:16:53 -0400 (EDT)

branch: feature/eglot2emacs
commit ef0da9414e148cafef7443660ac90c571850b629
Author: João Távora <joaotavora@gmail.com>
Commit: João Távora <joaotavora@gmail.com>

    Make eglot--plist-keys a simple (non-map.el) helper again
    
    This removes a nagging compilation warning when developing on Emacs
    master.
    
    There's not much point in depending on map.el just for this util.  And
    there' snot much point in making eglot--plist-keys go through a
    generic dispatching mechanism when we happen to know the thing
    being dispatched
    
    * eglot.el (eglot--plist-keys): Define in helpers section.
---
 lisp/progmodes/eglot.el | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 86e798fabd..f739a0d34d 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -1550,6 +1550,9 @@ and just return it.  PROMPT shouldn't end with a question 
mark."
   "Tell if SERVER's project root is `file-remote-p'."
   (file-remote-p (project-root (eglot--project server))))
 
+(defun eglot--plist-keys (plist) "Get keys of a plist."
+  (cl-loop for (k _v) on plist by #'cddr collect k))
+
 
 ;;; Minor modes
 ;;;
@@ -3078,13 +3081,6 @@ If NOERROR, return predicate, else erroring function."
 
 (make-obsolete-variable 'eglot--managed-mode-hook
                         'eglot-managed-mode-hook "1.6")
-
-(if (< emacs-major-version 27)
-    (defun eglot--plist-keys (plist)
-      (cl-loop for (k _v) on plist by #'cddr collect k))
-  ;; Make into an obsolete alias once we drop support for Emacs 26.
-  (defalias 'eglot--plist-keys #'map-keys))
-
 (provide 'eglot)
 
 ;; Local Variables:



reply via email to

[Prev in Thread] Current Thread [Next in Thread]