[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
feature/eglot2emacs 4beab004d9 070/120: Ensure exit-function of eglot-c-
From: |
João Távora |
Subject: |
feature/eglot2emacs 4beab004d9 070/120: Ensure exit-function of eglot-c-at-point runs on exact match |
Date: |
Thu, 20 Oct 2022 07:16:57 -0400 (EDT) |
branch: feature/eglot2emacs
commit 4beab004d98f17f830600b4597315f030a7313c3
Author: rbrtb <104695105+rbrtb@users.noreply.github.com>
Commit: GitHub <noreply@github.com>
Ensure exit-function of eglot-c-at-point runs on exact match
When the completion is exact match, exit-function should still run.
Say one is using auto-imports feature of pyright. One types foo, and
triggers the completion. There are two candidates: foo and foo_bar. If
one chooses foo, the status would be 'exact' instead of 'finished', thus
exit-function is not executed, foo is not auto-imported.
* eglot.el (eglot-completion-at-point): Consider 'exact status.
Copyright-paperwork-exempt: Yes
GitHub-reference: fix https://github.com/joaotavora/eglot/issues/941
---
lisp/progmodes/eglot.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 3d1b19c905..81c545e64f 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -2649,7 +2649,7 @@ for which LSP on-type-formatting should be requested."
(line-beginning-position))))
:exit-function
(lambda (proxy status)
- (when (eq status 'finished)
+ (when (memq status '(finished exact))
;; To assist in using this whole `completion-at-point'
;; function inside `completion-in-region', ensure the exit
;; function runs in the buffer where the completion was
- feature/eglot2emacs ae7315b5f1 016/120: ; fix license statement, (continued)
- feature/eglot2emacs ae7315b5f1 016/120: ; fix license statement, João Távora, 2022/10/20
- feature/eglot2emacs 49e46c3d53 017/120: Add up-to-date server executables for html/css/json, João Távora, 2022/10/20
- feature/eglot2emacs 34c7da506d 020/120: Support autoimporttext from pyright language server, João Távora, 2022/10/20
- feature/eglot2emacs 9adb310e08 021/120: Don't error out on unsupported diagnostic.codedescription, João Távora, 2022/10/20
- feature/eglot2emacs 0f44d338f1 025/120: Support optional diagnostic.tags, João Távora, 2022/10/20
- feature/eglot2emacs 0739cdcf20 031/120: Improve backwards-compatibility of eglot-mode-map, João Távora, 2022/10/20
- feature/eglot2emacs 9710754080 042/120: Add support for optional completionitem.tags, João Távora, 2022/10/20
- feature/eglot2emacs c2d97d22aa 056/120: Implement on-type-formatting support, João Távora, 2022/10/20
- feature/eglot2emacs 1d9542cbe8 059/120: Protect against empty firsttriggercharacter strings, João Távora, 2022/10/20
- feature/eglot2emacs a63916f928 062/120: Tweak eglot mode-line menus, João Távora, 2022/10/20
- feature/eglot2emacs 4beab004d9 070/120: Ensure exit-function of eglot-c-at-point runs on exact match,
João Távora <=
- feature/eglot2emacs 29f2ec2471 071/120: Consider diagnostic.code when generating flymake diagnostics, João Távora, 2022/10/20
- feature/eglot2emacs cc5d1a5a72 091/120: Always default eglot-strict-mode to nil, João Távora, 2022/10/20
- feature/eglot2emacs e74e199912 093/120: Add out-of-box support for perl lsp server, João Távora, 2022/10/20
- feature/eglot2emacs d2e842bbf5 098/120: Prefer documentchanges to changes in server-initiated edits, João Távora, 2022/10/20
- feature/eglot2emacs e5f77f8ca5 100/120: Rework readme.md about workspace configuration again, João Távora, 2022/10/20
- feature/eglot2emacs ec7d63cbe7 105/120: Don't return hash tables from e-w-configuration-plist, João Távora, 2022/10/20
- feature/eglot2emacs 1780b93d66 111/120: Make clojure-lsp handle more major modes at once, João Távora, 2022/10/20
- feature/eglot2emacs 0848387fa2 115/120: Fix docstring of eglot-list-connections-mode, João Távora, 2022/10/20
- feature/eglot2emacs cf0ba0197a 007/120: Add support for the mint language server, João Távora, 2022/10/20
- feature/eglot2emacs ed9800041e 029/120: * eglot.el (eglot--connect): display seconds on timeout., João Távora, 2022/10/20