emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 5176d00611: Avoid having the async compile log saying it's compil


From: Lars Ingebrigtsen
Subject: master 5176d00611: Avoid having the async compile log saying it's compiling loaddefs
Date: Mon, 17 Oct 2022 04:48:26 -0400 (EDT)

branch: master
commit 5176d006114390885a3a34fd80a8e25687558edc
Author: Lars Ingebrigtsen <larsi@gnus.org>
Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Avoid having the async compile log saying it's compiling loaddefs
    
    * lisp/loadup.el (featurep): Define the hash table in nativecomp
    builds (but not otherwise).  A more natural place to define this
    would be in comp.el, but comp.el isn't loaded yet when we load the
    .elc file that updates comp--no-native-compile.  We could change
    the load order and move the definition to comp.el, though.
    
    * lisp/emacs-lisp/bytecomp.el (byte-compile-from-buffer): Allow
    inhibiting nativecomp earlier (bug#57627).
    
    * lisp/emacs-lisp/comp.el (native-compile-async-skip-p): Use the data.
---
 lisp/emacs-lisp/bytecomp.el | 12 +++++++++---
 lisp/emacs-lisp/comp.el     |  1 +
 lisp/loadup.el              |  5 ++++-
 3 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 3ceb5da804..692a87f6d5 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -2323,9 +2323,15 @@ With argument ARG, insert value in current buffer after 
the form."
        (setq case-fold-search nil))
      (displaying-byte-compile-warnings
       (with-current-buffer inbuffer
-       (and byte-compile-current-file
-            (byte-compile-insert-header byte-compile-current-file
-                                         byte-compile--outbuffer))
+       (when byte-compile-current-file
+         (byte-compile-insert-header byte-compile-current-file
+                                      byte-compile--outbuffer)
+          ;; Instruct native-comp to ignore this file.
+          (when (bound-and-true-p no-native-compile)
+            (with-current-buffer byte-compile--outbuffer
+              (insert
+               "(when (boundp 'comp--no-native-compile)
+  (puthash load-file-name t comp--no-native-compile))\n\n"))))
        (goto-char (point-min))
        ;; Should we always do this?  When calling multiple files, it
        ;; would be useful to delay this warning until all have been
diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index 889bffa3f5..c300c44a8d 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -4119,6 +4119,7 @@ the deferred compilation mechanism."
 LOAD and SELECTOR work as described in `native--compile-async'."
   ;; Make sure we are not already compiling `file' (bug#40838).
   (or (gethash file comp-async-compilations)
+      (gethash (file-name-with-extension file "elc") comp--no-native-compile)
       (cond
        ((null selector) nil)
        ((functionp selector) (not (funcall selector file)))
diff --git a/lisp/loadup.el b/lisp/loadup.el
index c01c827a75..e940a32100 100644
--- a/lisp/loadup.el
+++ b/lisp/loadup.el
@@ -501,7 +501,10 @@ lost after dumping")))
                                          bin-dest-dir)
                      ;; Relative filename from the built uninstalled binary.
                      (file-relative-name file invocation-directory)))))
-              comp-loaded-comp-units-h))))
+              comp-loaded-comp-units-h)))
+  ;; Set up the mechanism to allow inhibiting native-comp via
+  ;; file-local variables.
+  (defvar comp--no-native-compile (make-hash-table :test #'equal)))
 
 (when (hash-table-p purify-flag)
   (let ((strings 0)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]