emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

emacs-28 2dcb1bc474: Mark a few more map tests as unstable on Emacs 28 (


From: Philipp Stephani
Subject: emacs-28 2dcb1bc474: Mark a few more map tests as unstable on Emacs 28 (Bug#46722).
Date: Sat, 15 Jan 2022 06:41:46 -0500 (EST)

branch: emacs-28
commit 2dcb1bc47485791177917bfbd8fba95d69454135
Author: Philipp Stephani <phst@google.com>
Commit: Philipp Stephani <phst@google.com>

    Mark a few more map tests as unstable on Emacs 28 (Bug#46722).
    
    At least for me, these tests still occasionally fail.
    
    Do not merge to master.
    
    * test/lisp/emacs-lisp/map-tests.el (test-map-into-hash-test)
    (test-map-merge, test-map-merge-with, test-map-merge-empty): Mark as
    unstable.
---
 test/lisp/emacs-lisp/map-tests.el | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/test/lisp/emacs-lisp/map-tests.el 
b/test/lisp/emacs-lisp/map-tests.el
index 31be0784ec..4fca8b3619 100644
--- a/test/lisp/emacs-lisp/map-tests.el
+++ b/test/lisp/emacs-lisp/map-tests.el
@@ -443,6 +443,9 @@ Evaluate BODY for each created map."
 
 (ert-deftest test-map-into-hash-test ()
   "Test `map-into' with different hash-table test functions."
+  ;; This test is unstable in Emacs 28, but the problem has been fixed
+  ;; in Emacs 29 (bug#46722).
+  :tags '(:unstable)
   (should (eq (hash-table-test (map-into () 'hash-table)) #'equal))
   (should (eq (hash-table-test (map-into () '(hash-table))) #'eql))
   (should (eq (hash-table-test (map-into () '(hash-table :test eq))) #'eq))
@@ -473,6 +476,9 @@ Evaluate BODY for each created map."
 
 (ert-deftest test-map-merge ()
   "Test `map-merge'."
+  ;; This test is unstable in Emacs 28, but the problem has been fixed
+  ;; in Emacs 29 (bug#46722).
+  :tags '(:unstable)
   (should (equal (sort (map-merge 'list '(a 1) '((b . 2) (c . 3))
                                   #s(hash-table data (c 4)))
                        (lambda (x y) (string< (car x) (car y))))
@@ -482,6 +488,9 @@ Evaluate BODY for each created map."
   (should (equal (map-merge 'plist () '(:a 1)) '(:a 1))))
 
 (ert-deftest test-map-merge-with ()
+  ;; This test is unstable in Emacs 28, but the problem has been fixed
+  ;; in Emacs 29 (bug#46722).
+  :tags '(:unstable)
   (should (equal (sort (map-merge-with 'list #'+
                                        '((1 . 2))
                                        '((1 . 3) (2 . 4))
@@ -494,6 +503,9 @@ Evaluate BODY for each created map."
 
 (ert-deftest test-map-merge-empty ()
   "Test merging of empty maps."
+  ;; This test is unstable in Emacs 28, but the problem has been fixed
+  ;; in Emacs 29 (bug#46722).
+  :tags '(:unstable)
   (should-not (map-merge 'list))
   (should-not (map-merge 'alist))
   (should-not (map-merge 'plist))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]