[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
scratch/bytecode-speedup d29877e58a 2/2: Implement Ffuncall in terms of
From: |
Mattias Engdegård |
Subject: |
scratch/bytecode-speedup d29877e58a 2/2: Implement Ffuncall in terms of funcall_general |
Date: |
Thu, 13 Jan 2022 12:27:37 -0500 (EST) |
branch: scratch/bytecode-speedup
commit d29877e58a8fe23e7764656371138ccab31d3ec0
Author: Mattias Engdegård <mattiase@acm.org>
Commit: Mattias Engdegård <mattiase@acm.org>
Implement Ffuncall in terms of funcall_general
* src/eval.c (funcall_general, Ffuncall): Delegate the actual work in
Ffuncall to funcall_general which does exactly this.
This slows down some less used function call paths by a small amount
but the code duplication was just silly.
---
src/eval.c | 44 ++++----------------------------------------
1 file changed, 4 insertions(+), 40 deletions(-)
diff --git a/src/eval.c b/src/eval.c
index 8fa1f7cba9..6469f11866 100644
--- a/src/eval.c
+++ b/src/eval.c
@@ -3031,6 +3031,7 @@ Lisp_Object
funcall_general (Lisp_Object fun, ptrdiff_t numargs, Lisp_Object *args)
{
Lisp_Object original_fun = fun;
+ retry:
if (SYMBOLP (fun) && !NILP (fun)
&& (fun = XSYMBOL (fun)->u.s.function, SYMBOLP (fun)))
fun = indirect_function (fun);
@@ -3056,7 +3057,8 @@ funcall_general (Lisp_Object fun, ptrdiff_t numargs,
Lisp_Object *args)
else if (EQ (funcar, Qautoload))
{
Fautoload_do_load (fun, original_fun, Qnil);
- return funcall_general (original_fun, numargs, args);
+ fun = original_fun;
+ goto retry;
}
else
xsignal1 (Qinvalid_function, original_fun);
@@ -3070,10 +3072,6 @@ Thus, (funcall \\='cons \\='x \\='y) returns (x . y).
usage: (funcall FUNCTION &rest ARGUMENTS) */)
(ptrdiff_t nargs, Lisp_Object *args)
{
- Lisp_Object fun, original_fun;
- Lisp_Object funcar;
- ptrdiff_t numargs = nargs - 1;
- Lisp_Object val;
ptrdiff_t count;
maybe_quit ();
@@ -3093,42 +3091,8 @@ usage: (funcall FUNCTION &rest ARGUMENTS) */)
if (debug_on_next_call)
do_debug_on_call (Qlambda, count);
- original_fun = args[0];
-
- retry:
-
- /* Optimize for no indirection. */
- fun = original_fun;
- if (SYMBOLP (fun) && !NILP (fun)
- && (fun = XSYMBOL (fun)->u.s.function, SYMBOLP (fun)))
- fun = indirect_function (fun);
+ Lisp_Object val = funcall_general (args[0], nargs - 1, args + 1);
- if (SUBRP (fun) && !SUBR_NATIVE_COMPILED_DYNP (fun))
- val = funcall_subr (XSUBR (fun), numargs, args + 1);
- else if (COMPILEDP (fun)
- || SUBR_NATIVE_COMPILED_DYNP (fun)
- || MODULE_FUNCTIONP (fun))
- val = funcall_lambda (fun, numargs, args + 1);
- else
- {
- if (NILP (fun))
- xsignal1 (Qvoid_function, original_fun);
- if (!CONSP (fun))
- xsignal1 (Qinvalid_function, original_fun);
- funcar = XCAR (fun);
- if (!SYMBOLP (funcar))
- xsignal1 (Qinvalid_function, original_fun);
- if (EQ (funcar, Qlambda)
- || EQ (funcar, Qclosure))
- val = funcall_lambda (fun, numargs, args + 1);
- else if (EQ (funcar, Qautoload))
- {
- Fautoload_do_load (fun, original_fun, Qnil);
- goto retry;
- }
- else
- xsignal1 (Qinvalid_function, original_fun);
- }
lisp_eval_depth--;
if (backtrace_debug_on_exit (specpdl + count))
val = call_debugger (list2 (Qexit, val));