emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 69f1bc4 2/2: Turn mistaken functions into tests (bug#51941)


From: Mattias Engdegård
Subject: master 69f1bc4 2/2: Turn mistaken functions into tests (bug#51941)
Date: Thu, 18 Nov 2021 14:55:17 -0500 (EST)

branch: master
commit 69f1bc43c026049ed2aab6a6368e2e9a5406b779
Author: Mattias Engdegård <mattiase@acm.org>
Commit: Mattias Engdegård <mattiase@acm.org>

    Turn mistaken functions into tests (bug#51941)
    
    * test/lisp/calendar/icalendar-tests.el
    (icalendar-tests--decode-isodatetime):
    * test/src/eval-tests.el
    (eval-tests-19790-backquote-comma-dot-substitution):
    Change `defun` into `ert-deftest` where this seems to have been the
    original intention.
---
 test/lisp/calendar/icalendar-tests.el | 2 +-
 test/src/eval-tests.el                | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/lisp/calendar/icalendar-tests.el 
b/test/lisp/calendar/icalendar-tests.el
index 9e8a8e7..10b684a 100644
--- a/test/lisp/calendar/icalendar-tests.el
+++ b/test/lisp/calendar/icalendar-tests.el
@@ -1633,7 +1633,7 @@ SUMMARY:NNN Wwwwwwww Wwwww - Aaaaaa Pppppppp rrrrrr ddd 
oo Nnnnnnnn 30
   (let ((time (icalendar--decode-isodatetime string day zone)))
     (format-time-string "%FT%T%z" (encode-time time) 0)))
 
-(defun icalendar-tests--decode-isodatetime (_ical-string)
+(ert-deftest icalendar-tests--decode-isodatetime ()
   "Test `icalendar--decode-isodatetime'."
   (should (equal (icalendar-test--format "20040917T050910-0200")
                  "2004-09-17T03:09:10+0000"))
diff --git a/test/src/eval-tests.el b/test/src/eval-tests.el
index 3c3e703..4f05d99 100644
--- a/test/src/eval-tests.el
+++ b/test/src/eval-tests.el
@@ -179,7 +179,7 @@ are found on the stack and therefore not garbage collected."
   "Remove the Lisp reference to the byte-compiled object."
   (setf (symbol-function #'eval-tests-33014-func) nil))
 
-(defun eval-tests-19790-backquote-comma-dot-substitution ()
+(ert-deftest eval-tests-19790-backquote-comma-dot-substitution ()
   "Regression test for Bug#19790.
 Don't handle destructive splicing in backquote expressions (like
 in Common Lisp).  Instead, make sure substitution in backquote



reply via email to

[Prev in Thread] Current Thread [Next in Thread]