emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 57d54bb: Improve defface error message


From: Lars Ingebrigtsen
Subject: master 57d54bb: Improve defface error message
Date: Thu, 4 Nov 2021 14:23:46 -0400 (EDT)

branch: master
commit 57d54bb49ddddf91a94a5aba4cb20899665653ac
Author: Lars Ingebrigtsen <larsi@gnus.org>
Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Improve defface error message
    
    * lisp/cus-face.el (custom-declare-face): Improve the error
    message when there's a missing doc string (bug#51576).
---
 lisp/cus-face.el | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lisp/cus-face.el b/lisp/cus-face.el
index 6c0052b..5037ee7 100644
--- a/lisp/cus-face.el
+++ b/lisp/cus-face.el
@@ -31,6 +31,9 @@
 
 (defun custom-declare-face (face spec doc &rest args)
   "Like `defface', but with FACE evaluated as a normal argument."
+  (when (and doc
+             (not (stringp doc)))
+    (error "Invalid (or missing) doc string %S" doc))
   (unless (get face 'face-defface-spec)
     (face-spec-set face (purecopy spec) 'face-defface-spec)
     (push (cons 'defface face) current-load-list)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]