coposys-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Coposys-dev] Re: patch for update.


From: Cyril Bouthors
Subject: [Coposys-dev] Re: patch for update.
Date: Sat, 28 Jul 2001 13:36:36 +0200

Francois TOURDE writes:
 > +     if ( param('update') ) {
 > +    if (
 > +        param('name') &&
 > +        param('password') &&
 > +        !param('password2') &&   <---
 > +        param('latitude') &&
 > +        param('longitude') &&
 > +        param('email') &&
 > +        param('community') 
 > +        )
 > +    {
 > +        update_name();
 > +    }
 > +    else {
 > +        html_error('Missing argument or password entered twice for update 
 > !');
 > +    }

It's  a detail  but why  not simply  ignoring 'password2'  in  case of
update (we don't care if it is defined or not) ?

Anyway, the patch  is good, I've applied it to the  CVS tree almost as
is.

Thank you.
-- 
Cyril Bouthors -- phone:+33 1 41 66 47 06
                    fax:+33 1 41 66 47 10



reply via email to

[Prev in Thread] Current Thread [Next in Thread]