bug-readline
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] readline: guard sigprocmask call on platforms that have it


From: Chet Ramey
Subject: Re: [PATCH] readline: guard sigprocmask call on platforms that have it
Date: Sat, 6 Feb 2021 12:31:56 -0500
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 2/6/21 10:30 AM, Sergei Trofimovich wrote:
Noticed the build problem on i686-w64-mingw32 target as:

```
i686-w64-mingw32-gcc -c  -DHAVE_CONFIG_H -DCROSS_COMPILING  -I. -I.  
-DRL_LIBRARY_VERSION='"8.1"' -DBRACKETED_PASTE_DEFAULT=1 -g -O2 
-Wno-parentheses -Wno-format-security signals.c
signals.c: In function '_rl_handle_signal':
signals.c:270:2: warning: implicit declaration of function 'sigprocmask' 
[-Wimplicit-function-declaration]
   270 |  sigprocmask (SIG_BLOCK, &set, &oset);
       |  ^~~~~~~~~~~
signals.c:270:15: error: 'SIG_BLOCK' undeclared (first use in this function); 
did you mean 'SIG_ACK'?
   270 |  sigprocmask (SIG_BLOCK, &set, &oset);
       |               ^~~~~~~~~
       |               SIG_ACK
signals.c:270:15: note: each undec
```

The change guards sigprocmask() the same way SIG_UNBLOCK
is guarded a few lines below.

Thanks for the report.

Chet

--
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]