[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint: Allow gnulib's readutmp module to use systemd.
From: |
Simon Josefsson |
Subject: |
Re: [PATCH] maint: Allow gnulib's readutmp module to use systemd. |
Date: |
Fri, 22 Mar 2024 22:18:12 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Collin Funk <collin.funk1@gmail.com> writes:
> Hi Simon,
>
> On 3/22/24 12:51 PM, Simon Josefsson wrote:
>> Hi. Nice catch, thank you. I have added a CI/CD job to catch -lsystemd
>> regressions in the future:
>
> Nice, looks good to me.
>
>> Thank you for details -- I think this is somewhat subjective, but I do
>> prefer to augment as specific LDADD's as possible when it is known how
>> to do so. If the library was used by 75% of the binaries, I wouldn't
>> had bothered, but I think this is a small enough subset to care about.
>
> Yes, good point. Just to double check I reconfigured and run
> 'make all && make check' and everything works as expected. Thanks.
Great!
>> I pushed the following patch in your name, adding a NEWS entry and the
>> moniker 'tiny patch' to indicate that signing copyright papers are not
>> necessary. I appreciate you taking the time to prepare a patch, though,
>> and would be happy if you continued to do so, and then copyright papers
>> will be required at some point so let me know off-list and I'll send you
>> the proper form to fill out.
>
> Thanks! Yes, it would be nice to have copyright papers submitted so I
> can submit patches again in the future. I just recently signed them
> for gnulib since I started working on gnulib-tool.py.
Upgrading inetutils to use gnulib-tool.py would be nice. As a start, I
bumped the gnulib submodule.
> I imagine it is the same process as that but s/gnulib/inetutils ? Feel
> free to email me off-list.
Done.
/Simon
signature.asc
Description: PGP signature