bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Treat single space table entry names specially, i.e., reject the


From: Erik Auerswald
Subject: [PATCH] Treat single space table entry names specially, i.e., reject them
Date: Sat, 12 Feb 2022 21:06:07 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Hi,

some tables used with "genget()" use table entries with a single space
character as entry name for special purposes, i.e., as empty lines or
comment lines.  Thus an entry with name " " is not intended as a valid
table entry, but "genget()" does not treat those entries differently from
valid antries.  It should instead reject any attempt to get the entry to
the name " ".

Rejecting to get the table entry for " " would have masked that both
setcmd() and unsetcmd() are not able to handle those table entries.
Thus this rejecting the name " " can be seen to improve robustness.

The attached patch "inetutils-libtelnet-genget-no_space_command.patch"
implements this.

[The genget() function requires "name" to be a valid C string already.]

Thanks,
Erik
-- 
The computing scientist’s main challenge is not to get confused by
the complexities of his own making.
                        -- Edsger W. Dijkstra

Attachment: inetutils-libtelnet-genget-no_space_command.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]