bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Rephrase recent change history.


From: Mats Erik Andersson
Subject: Re: [PATCH] Rephrase recent change history.
Date: Fri, 8 May 2020 14:52:49 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

Tordag den 7:e maj 2020, klockan 15:47, skrev Alfred M. Szmidt detta:
>    Complaints? Remarks? Opposition?
> 
>    For my part, this would put our controversy ad actam.
> 
> LGTM.

What does the acrynom "LGTM" stand for?

>    +  * ChangeLog: Rephrase description of some implemented changes.
> 
> We don't (generally) mention changes to random text files in the
> repository; other than maybe "Updated." -- but its up to you if you
> want to keep this or not.

Well, our file ChangeLog can hardly be said to be a "random file"!

I agree that inserting new entries into ChangeLog should not be
advertised as such, but this time I am rewriting previous entries,
thus making changes to the recorded history. This merits a distinct
entry in my opinion, in order that an uncertain future be able to
identify the steps undertaken by a project member, intended to
clarify whatever measures seemed necessary at some past time.
You admitted yourself at the beginning of April that you could
foresee an attempt of mine to rephrase the changelog entries
you had created for previous commits. Now I make my move!

Observe that my change set rectifies incorrect mention of "dologout",
"Usernaem", "callees", improves details of change set, and performs
minor rephrasing of style, like reducing duplicate text. I had rather
wanted comments on these points, than having to fumble with glyphs.

Best regards,
  Mats E A



reply via email to

[Prev in Thread] Current Thread [Next in Thread]