bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-inetutils] On the use of non-exiting error().


From: Alfred M. Szmidt
Subject: Re: [bug-inetutils] On the use of non-exiting error().
Date: Wed, 19 Jan 2011 13:06:54 -0500

   > Error and warning messages should start in lower case as well, and not
   > end in with a end of sentence period (think there is a mention of that
   > in the GCS).

   There is no single "fprintf" in that file "src/logger.c", but many
   error(...) calls. It is a legitimite use to issue error(EXIT_SUCCESS,...)
   since it only emits a message to STDERR and does nothing else.

error (0, ...) are basically warning messages.

   The naught in  "error( , 0, "print-me" )" ensures that no implicit error
   message is added, only the explicit "print-me" in this case (and progname).

   Do you claim that GNU opposes to this practice, which is clearly stated
   in the manpage error(3)?

Sorry, I was unclear, instead of:

  error (EXIT_SUCCESS, 0, MSG);

one should write:

  error (0, 0, MSG);

It is missleading to use EXIT_SUCCESS here since we do not actually
exit the program at this point.   



reply via email to

[Prev in Thread] Current Thread [Next in Thread]