bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-inetutils] Re: [PATCH] Make `logger' IPv6-capable.


From: Alfred M. Szmidt
Subject: Re: [bug-inetutils] Re: [PATCH] Make `logger' IPv6-capable.
Date: Wed, 19 Jan 2011 11:41:27 -0500

   > > Now both are implemented, but '--ipv6' prints a warning message to
   > > STDOUT and falls back to IPv4 if the system is not compiled with IPv6
   > > support.

   One correction: The warning goes to STDERR, since it is generated
   by a call

      error(EXIT_SUCCESS, 0, "Warning: Falling back to IPv4, ...").

Please don't use EXIT_SUCCESS for error calls (it doesn't exit).
Error and warning messages should start in lower case as well, and not
end in with a end of sentence period (think there is a mention of that
in the GCS).

   > Would an error be more appropriate?  I'm thinking scripted use.  OTOH,
   > for logger you would probably prefer to get the log delivered than not
   > to.  Could it log an error message? ;)

   I do not understand acronyms like "OTOH", which influences this comment.
   Is my understanding correct in observing these two features?

OTOH - On the other hand. ;-)

   a) Do you like the call "logger --ipv6 ..." to print the warning to stderr,
      attempt the requested logging message via IPv4, and also exit execution
      with a non-zero exit code? Presently the exit code is zero, but the
      other two parts are included in my suggestion.

I think just a warning is enough, if it can use IPv4.  Though Simon
has a point in making it a error.  I'm for either.

   b) Do you desire the IPv6 failure to log a local message about the
      inability to use that transport, thus produc>ing two log messages:
      the intended text which is possibly non-local and the additional
      failure report which remains on the local workstation/server?

I think that might be a good idea.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]