bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-inetutils] [PATCH] Fix compiler warnings


From: Giuseppe Scrivano
Subject: Re: [bug-inetutils] [PATCH] Fix compiler warnings
Date: Thu, 03 Dec 2009 20:58:14 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux)

"Alfred M. Szmidt" <address@hidden> writes:

>    > --- a/inetd/inetd.c
>    > +++ b/inetd/inetd.c
>    > @@ -1013,7 +1011,7 @@ getconfigent (FILE *fconfig, const char *file, 
> size_t *line)
>    >  {
>    >    static struct servtab serv;
>    >    struct servtab *sep = &serv;
>    > -  size_t argc = 0, i;
>    > +  int argc = 0, i;
>    >    char **argv = NULL;
>    >    char *node, *service;
>    >    static char TCPMUX_TOKEN[] = "tcpmux/";
>
>    This was not documented in the ChangeLog. And it seems to me only ā€˜iā€™
>    needs to be size_t, and argc would be better left as int to match
>    normal argc/argv types.
>
> Good catch! Giuseppe, could you fix the ChangeLog to reflect this
> change?

Yes, I am going to fix it.  Thanks!


Giuseppe




reply via email to

[Prev in Thread] Current Thread [Next in Thread]