Re: [bug-inetutils] [PATCH] Fix compiler warnings

[Guillem Jover]

Hi!

On Thu, 2009-12-03 at 16:38:37 +0100, Giuseppe Scrivano wrote:
> This patch fixes any warning reported by gcc 4.3.4 (I haven't yet tried
> with newer versions).  All of them are trivial changes but given the
> patch size, I think it is better to postpone it after the release.
> 
> Any comment?

> From 49b743add1d0cb2e1e16df8ddd8a442c2c5bced1 Mon Sep 17 00:00:00 2001
> From: Giuseppe Scrivano <address@hidden>
> Date: Thu, 3 Dec 2009 16:16:55 +0100
> Subject: [PATCH] Fix compiler warnings

> +     * inetd/inetd.c (expand_enter): Remove unused variables.

> diff --git a/inetd/inetd.c b/inetd/inetd.c
> index f2c1e3b..072702b 100644
> --- a/inetd/inetd.c
> +++ b/inetd/inetd.c
> @@ -1013,7 +1011,7 @@ getconfigent (FILE *fconfig, const char *file, size_t 
> *line)
>  {
>    static struct servtab serv;
>    struct servtab *sep = &serv;
> -  size_t argc = 0, i;
> +  int argc = 0, i;
>    char **argv = NULL;
>    char *node, *service;
>    static char TCPMUX_TOKEN[] = "tcpmux/";

This was not documented in the ChangeLog. And it seems to me only ‘i’
needs to be size_t, and argc would be better left as int to match
normal argc/argv types.

regards,
guillem