Re: [bug-inetutils] [PATCH] ftpd

[Alfred M. Szmidt]

Please reply to the list.

   Thank you for your feedback. I should point out that it is Richard
   Stallman's vision that I believe in not Eric Raymond's. I will be more
   careful in the future with the terminology that I use :-)

It is more useful to believe in freedom than in someones vision, since
a persons vision can change, but freedom does not.

   I have made most of the changes that you suggested and will supply
   a new patch shortly.

Thank you!

   The reason that I passed in port as a separate argument to server_mode
   is because phis->sin_port is used for the data port. The command port
   is set via server_addr.sin_port.

I do not follow...  I wasn't referring to sin_port, but to the usage
of "port = port_no;" in server_mode, which is redundant.

   Do we want to allow a user to specify 0 as a port number? I realise
   this will cause the port to be generated dynamically. Not sure
   about other FTP servers but I do not think the Solaris in.ftpd
   allows you to use 0.

Could you check?  I have no preference if we accept 0 or not, but it
is a valid port number.