bug-inetutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-inetutils] [patch] fix implicit and invalid casts from pointer


From: Alfred M. Szmidt
Subject: Re: [bug-inetutils] [patch] fix implicit and invalid casts from pointer to int
Date: Fri, 23 Jun 2006 01:34:59 +0200 (CEST)

CCing Dann.  Guillem, were you having problems with your mail server?
I noticed that the messages are dated March 24th, but it recived them
on July 19th.

   ftp/ChangeLog
   2006-03-24  Dann Frazier  <address@hidden>

           * main.c [HAVE_LIBREADLINE]: Include 'readline/readline.h'.

Already fixed by the following:

2006-04-20  Sergey Poznyakoff  <address@hidden>

        * main.c [HAVE_READLINE_READLINE_H]: Include <readline/readline.h>

   headers/ChangeLog
   2006-03-24  Dann Frazier  <address@hidden>

           * Makefile.am (noinst_HEADERS): Add 'utmp_init.h'.
           * utmp_init.h: New file.

   rlogind/ChangeLog
   2006-03-24  Dann Frazier  <address@hidden>

           * rlogind.c: Include 'utmp_init.h'. Add prototype for localhost.
           Move protypes for utmp_ptsid and utmp_init to 'utmp_init.h'.

   telnetd/ChangeLog
   2006-03-24  Dann Frazier  <address@hidden>

           * Makefile.am (INCLUDES): Add '-I$(top_srcdir)/headers'.
           * pty.c: Include 'utmp_init.h'.

How about the following fix instead?

Index: rlogind/ChangeLog
2006-06-23  Alfred M. Szmidt  <address@hidden>

        * rlogind.c: Added extern declaration for localhost();
        [UTMPX]: Added proper extern declarations for utmp_init() and
        utmp_ptsid().  Reported by Dann Frazier <address@hidden>.

Index: rlogind/rlogind.c
===================================================================
RCS file: /cvsroot/inetutils/inetutils/rlogind/rlogind.c,v
retrieving revision 1.35
diff -p -u -r1.35 rlogind.c
--- rlogind/rlogind.c   20 Apr 2006 09:17:15 -0000      1.35
+++ rlogind/rlogind.c   22 Jun 2006 23:32:10 -0000
@@ -132,6 +132,7 @@
 # define DEFPORT 513
 #endif
 extern int      __check_rhosts_file;
+extern char *localhost (void);
 
 #ifndef SHISHI
 struct auth_data
@@ -636,8 +637,8 @@ setup_tty (int fd, struct auth_data *ap)
 }
 
 #ifdef UTMPX
-char           *utmp_ptsid ();
-/*FIXME*/ void  utmp_init ();
+extern void utmp_init(char *line, char *user, char *id);
+extern char *utmp_ptsid(char *line, char *tag);
 
 void
 setup_utmp (char *line)

Index: telnetd/ChangeLog
2006-06-23  Alfred M. Szmidt  <address@hidden>

        * pty.c: Added extern declarations for utmp_init() and
        utmp_ptsid().  Reported by Dann Frazier <address@hidden>.

Index: telnetd/pty.c
===================================================================
RCS file: /cvsroot/inetutils/inetutils/telnetd/pty.c,v
retrieving revision 1.5
diff -p -u -r1.5 pty.c
--- telnetd/pty.c       20 Apr 2006 09:17:15 -0000      1.5
+++ telnetd/pty.c       22 Jun 2006 23:32:26 -0000
@@ -1,4 +1,4 @@
-/* Copyright (C) 1998,2001 Free Software Foundation, Inc.
+/* Copyright (C) 1998,2001,2006 Free Software Foundation, Inc.
 
    This file is part of GNU Inetutils.
 
@@ -25,6 +25,9 @@
 #endif
 #include <libinetutils.h>
 
+extern void utmp_init (char *line, char *user, char *id);
+extern char *utmp_ptsid (char *line, char *tag);
+
 void
 setup_utmp (char *line)
 {




reply via email to

[Prev in Thread] Current Thread [Next in Thread]