Re: Fwd: [bug-inetutils] [PATCH] fix whitespace parsing in syslogd

[Julian Gilbey]

On Fri, Aug 29, 2003 at 04:13:11PM +0000, Robert Millan wrote:
> 
> Hi Julian,
> 
> Upstream revised your patch and provides a new version (attached). Please
> could you tell us wether this one fixes it?

This would appear to fix the continuation line part; however, the
patch I submitted also fixed another part of the code, which dealt
with the input line being too long.  I wouldn't want to see that lost,
either.

> Also, IIRC you sent me a syslog.conf in your past report. Do you want me
> to include it in the package?

It was pulled direct from sysklogd.  You've got to coordinate with the
maintainer of that package, because it's a conffile there.

> On Fri, Aug 29, 2003 at 03:11:15PM +0200, Marcus Brinkmann wrote:
> > On Thu, Aug 28, 2003 at 07:32:18PM +0000, Robert Millan wrote:
> > > > *.=info;*.=notice;*.=warn;\
> > > >         auth,authpriv.none;\
> > > >         cron,daemon.none;\
> > > >         mail,news.none          -/var/log/messages
> > 
> > Note that this makes it non-intuitive how to split a selector from the
> > action.  You would have to use:
> > 
> > *.=info \
> >     -/var/log/messages
> > 
> > while
> > *.=info\
> >     -/var/log/messages
> > 
> > would be wrong.  Anyway, can you please test this patch?  If it does solve 
> > the
> > problem for you, I can check it in.

A way of checking this would be: if the line ends with the (Perl)
regexp: /;\s*\\$/, then strip any white-space before the '\' and at
the beginning of the new line, otherwise leave the whitespace.

   Julian

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

        Julian Gilbey, website: http://www.polya.uklinux.net/
   Debian GNU/Linux Developer, see: http://people.debian.org/~jdg/
     Visit http://www.thehungersite.com/ to help feed the hungry