Re: ifconfig and some minor fixes.

[Alain Magloire]

> 
> On Fri, Jun 22, 2001 at 11:36:30PM -0400, Alain Magloire wrote:
> > - Patches provided by Sergey for solaris.c
> >   configure.in, options.c.
> >   Not sure I understand the #include <sys/sockio.h>
> >   but I've use it in if_index.c too.
> 
> We should remove it if nobody knows what it is for.  Sergey?
> (I don't want to start the first release of ifconfig with anonymous cruft ;)
> 
> Thanks for the fixes.  I have done a couple of clean ups:
> 
> I put the HAVE_IFREQ_IFR_NETMASK etc in system.h.  It was gross to put them
> in printif.h, and it is not true that there is no better place.  system.h is
> the common interface to all system specific header files, and included for
> all ifconfig files very early.

Ok.

> 
> I reverted the SYSTEM_{SHORT,LONG}_OPTIONS change in options.c.  I don't
> know why everybody thinks they should be defined.  They are only to be
> defined if the system provides additional options.  I plan to use them to
> decide if such options are provided later on.  Defining them to nothing will
> defeat this.  Every place where they are used (only one currently, this is
> still not worked out) will be protected by #ifdef.

Ha! Ok.

> qnx.h still defined ifr_netmask to ifr_address, I have removed this now that
> we have the generic adaption.  I also removed the qfh_ functions (the whole
> idea of ifconfig is to provide generic code for these if possible at all)
> and their prototypes.

Ok.

> There is one grief I have with your changes:  if_index.c is nice, but it is
> too strong.  On a system which has if_nameindex, but not SIOCGIFCONF, it
> will override the systems implementation and just return ENOSYS.
> 
> I would rather have it not included by default, and only include it if we
> opt for it or if_nameindex is not available.  I don't care if the list we
> opt for is long, because currently many if_nameindex are broken or
> incomplete.  As far as I can see, if_nameindex becomes quite standard with
> the upcoming POSIX draft.

Allright then, lets move if_nameindex.[ch] in libinetutils or
libifconfig 8-)? and do some basic checks in configure.in.

> 
> What I really have to do soon is to implement support to change flags. 

Cool.

P.S.: Some of your comments seem to imply that you've done a certain
      number of things but it was not commited.

--
alain