Re: ifconfig and some minor fixes.

[Marcus Brinkmann]

On Tue, Jun 05, 2001 at 01:40:19AM +0300, Sergey Poznyakoff wrote:
> On Solaris `struct sockaddr' is defined in sys/socket.h, if the header
> is not included before <net/if.h> compilation bails out on any member
> of `struct  sockaddr' type it encounters. It is surely not needed on
> `normal' systems, but it doesn't hurt anyway, so I have #included it
> unconditionally.

Ok.
 
> > MB: I'd prefer to do
> > #define ifr_netmask ifr_addr
> > on such systems.  Is Solaris such a system?
> Yes, unfortunately it is :( Actually it is the most brain-damaged
> system I ever worked with, and that is why I am trying to make 
> inetutils work on it: if it compiles there it will compile anywhere :^).

;)

As long as we make such work arounds local to solaris.c, and transparent (so
we know why we need this), I'm fine.
 
> >   * ifconfig/system.c, ifconfig/system.h: added ifdef __sun__ clause
> > MB: What's the story between __sun__ and __solaris__?  I changed __solaris__
> > to __sun__ now, as I don't remember why I put __solaris__ there.  Do older
> > systems define __sun__, too?
> All systems I had access to define __sun__, but I suppose 
> #ifdef __solaris__ won't hurt either.

Better not.  If it is necessary, someone will tell us ;)
 
> >   * ifconfig/system/solaris.c: Added system_configure().
> > MB: Has Solaris IFTXQLEN? What is the FIXME supposed to mean?
> Well, I am not sure about a correct way to set txqlen. There surely
> must be a way to do this, but I still haven't found it. That's why
> I have marked the spot with FIXME.

Ah, wait.  I see now.  I never really finished solaris.c, and all this
txqlen code might just be from copying the linux file over.  So, if Solaris
doesn't define SIOCSIFTXQLEN and doesn't allow to change it the way the code
is right now, we should probably just remove this code parts.

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' Debian http://www.debian.org address@hidden
Marcus Brinkmann              GNU    http://www.gnu.org    address@hidden
address@hidden
http://www.marcus-brinkmann.de