Re: [bug-gv] [bug #19632] quiet and .gv watch settings are not respected

[John Bowman]

> Update of bug #19632 (project gv):
> 
>                   Status:                   Fixed => Need Info              
>              Assigned to:                 jemarch => None                   
>              Open/Closed:                  Closed => Open                   
> 
>     _______________________________________________________
> 
> Follow-up Comment #2:
> 
> Patch reverted. Does not work as expected: gv /bin/ls does _not_ prived an
> error message.
> 
> Thus bug reopened, as the fix has been removed.

Hi Markus,
   
Glad you have been able to take over as maintainer!

The patch in question fixed 2 problems (sorry it probably should have been
2 separate patches). If you want to disable the quiet setting again I think all
you need to do is remove from info.c the line

if(gv_gs_quiet) return;

Better yet, this conditional should be disabled only if gs returns with
exit code 1.

The entry for the quiet option in the man page should then be updated
to explain this more sensible behaviour. Or, if we really want to restore
the old and rather annoying behaviour of the quiet option, we should at
least add a "silent" option so that gs popups about (in practice very
common) noncompliant PostScript can be avoided. The silent setting would be
even stronger than quiet in that it will suppress all warnings and errors.

Regards,

-- John

P.S. Here's the original patch for reference:

diff -ru gv-3.6.2/src/info.c gv-3.6.2J/src/info.c
--- gv-3.6.2/src/info.c                   2004-11-11 05:21:05.000000000 -0700
+++ gv-3.6.2J/src/info.c                  2007-04-18 15:16:22.000000000 -0600
@@ -76,6 +76,7 @@
    Widget           w;
    XtPointer        client_data, call_data;
 {
+   if(gv_gs_quiet) return;
    BEGINMESSAGE(cb_popupInfoPopup)
    if (!infoPopupCreated) { makeInfoPopup(); }
    if (infoPopupVisible==True) {INFMESSAGE(InfoPopup already up) ENDMESSAGE(pop
upInfoPopup) return; }
diff -ru gv-3.6.2/src/main.c gv-3.6.2J/src/main.c
--- gv-3.6.2/src/main.c                   2006-09-14 12:56:08.000000000 -0600
+++ gv-3.6.2J/src/main.c                  2007-04-18 15:16:03.000000000 -0600
@@ -594,7 +594,7 @@
      XrmDatabase db;
      INFMESSAGE(getting resources)
      db = resource_buildDatabase(gv_display,gv_class,gv_name,&argc,argv);
-     XrmCombineDatabase(db,&gv_database,False);
+     XrmCombineDatabase(db,&gv_database,True);
    }
 
 /*### initializing widget set and creating application shell ##################
#######*/
@@ -1033,8 +1033,7 @@
             XtSetArg(args[n], XtNinterpreter,gv_gs_interpreter);
                   n++;
             b = gv_gs_safer ? True : False;
             XtSetArg(args[n], XtNsafer,b);                              n++;
-            b = gv_gs_quiet ? True : False;
-            XtSetArg(args[n], XtNquiet,b);                              n++;
+            XtSetArg(args[n], XtNquiet,True);                              n++;
             b = app_res.use_bpixmap ? True : False;
             XtSetArg(args[n], XtNuseBackingPixmap,b);                   n++;
             XtSetArg(args[n], XtNarguments,gv_gs_arguments);            n++;

> 
> 
> Status set to "Need info", because I am not quite sure about the desired
> behavior. More on this later.
> 
>     _______________________________________________________
> 
> Reply to this item at:
> 
>   <http://savannah.gnu.org/bugs/?19632>
> 
> _______________________________________________
>   Nachricht geschickt von/durch Savannah
>   http://savannah.gnu.org/
> 
> 
> 
>