[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/6] Modernize AC_INCLUDES_DEFAULT and friends.
|
From: |
Zack Weinberg |
|
Subject: |
Re: [PATCH 3/6] Modernize AC_INCLUDES_DEFAULT and friends. |
|
Date: |
Sat, 21 Sep 2013 20:05:40 -0400 |
On Sat, Sep 21, 2013 at 9:29 AM, Eric Blake <address@hidden> wrote:
> On 09/14/2013 10:22 AM, Zack Weinberg wrote:
...
>> (AC_HEADER_STDC, AC_UNISTD_H): AU_DEFUN to trigger
>> _AC_INCLUDES_DEFAULT_REQUIREMENTS if it hasn't already happened,
>> and do nothing else.
...
> Ah, I see what you did - you expanded to ac_dummy="AC_INCLUDES_DEFAULT"
> rather than actually spelling out the internal macro name - it triggers
> the internal macro via AC_REQUIRES magic. Interesting :)
Right. (In case you're wondering, the AS_IF is to ensure that the
AC_REQUIRE expansion happens before the beginning of the
ac_dummy="..." statement.)
Given that, do you still want patch 6?
I have made all the changes you requested (throughout the patch
series), and will go ahead and push once you answer this question. :)
zw
[PATCH 6/6] Expose the checks done by AC_INCLUDES_DEFAULT as a public macro., Zack Weinberg, 2013/09/15
[PATCH 5/6] Use AC_CHECK_{DECLS, FUNCS, HEADERS}_ONCE more in specific-check macros., Zack Weinberg, 2013/09/15
[PATCH 2/6] AC_CHECK_HEADER/AC_CHECK_HEADERS: complete transition to compile tests., Zack Weinberg, 2013/09/15
[PATCH 1/6] * tests/local.at (AT_CHECK_M4): Support 'stderr' as fourth argument., Zack Weinberg, 2013/09/15