autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] AC_INIT: properly quote package name containing m4 macro


From: Ralf Corsepius
Subject: Re: [PATCH] AC_INIT: properly quote package name containing m4 macro
Date: Mon, 21 Mar 2011 12:45:25 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7

On 03/20/2011 06:32 PM, Dave Hart wrote:
On Sat, Mar 19, 2011 at 04:27 UTC, Ralf Corsepius wrote:
My use case is to set the version number consistently inside of a package
(package suite) which consists of several sub-packages.

To achieve this, I have two aclocal *.m4s containing something similar to
this:
aclocal/version.m4:
AC_DEFUN([XXXX_VERSIONING],
m4_define([_XXXX_VERSION],[1.2.99.0]))
m4_define([_XXXX_API],[1.3])

aclocal/init.m4:
AC_DEFUN([XXXX_INIT],
[AC_REQUIRE([XXXX_VERSIONING
AC_PREFIX_DEFAULT([/opt/XXXX-][_XXXX_API])
])

... accompanied by this in configure.ac's:
AC_INIT([XXXX],[_XXXX_VERSION],[http://www.XXXX.org/bugzilla])
By my reading, Eric is proposing to require the first argument, the
package name, be unexpanded.  You care about the 2nd argument being
expanded, so I'm wondering if Eric's proposal impacts your use at all.
Though it's correct, I am only applying this approach to arg 2 of AC_INIT, it used to be applicable to all arguments of AC_INIT. I only don't do so, because args #1, #3 and #4 don't change frequently, while arg #2 (The version) does.

That said, I find Eric's patch to be inconsistent - It should be either all or none.

If expanding AC_INIT's second argument would be impacted, I think NTP
may be affected as well:
Thanks for mentioning ntp as also being one these packages. I'd assume there are many more, esp. amongst bigger packages with a long history.

Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]