[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] {master} Tests: normalize use of the 'errexit' shell flag.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] {master} Tests: normalize use of the 'errexit' shell flag. |
Date: |
Sun, 9 Jan 2011 07:24:50 +0100 |
User-agent: |
Mutt/1.5.20 (2010-08-04) |
* Eric Blake wrote on Sat, Jan 08, 2011 at 10:40:11PM CET:
> > If we can find and correct it; I suggest the first patch below,
> > otherwise the second. OK to push?
> Let's go with a third option - start with the second,
>
> > docs: link to 'set -e' shell behavior overview.
> >
> > * doc/autoconf.texi (Limitations of Builtins): Add link to
> > Sven Mascheck's 'set -e' page. Remove broken Opengroup link.
> > Suggestion by Eric Blake.
>
> but rather than deleting the broken Opengroup link, replace it with the
> working link to the latest POSIX wording:
>
> http://www.austingroupbugs.net/view.php?id=52
>
> Thanks for getting to it before me, and pre-approved to push once you
> make that change.
Thanks for the research and review. Incorporating the above link, I
ended up more or less going with my first proposed patch. This is what
I'm pushing now, feel free to improve if you like.
Cheers,
Ralf
docs: link to 'set -e' shell behavior overview.
* doc/autoconf.texi (Limitations of Builtins): Add link to
Sven Mascheck's 'set -e' page. Replace broken Opengroup link.
Suggestion by Eric Blake.
diff --git a/doc/autoconf.texi b/doc/autoconf.texi
index be1ef5b..3b7fde6 100644
--- a/doc/autoconf.texi
+++ b/doc/autoconf.texi
@@ -17382,11 +17382,11 @@ Limitations of Builtins
@cindex @command{set -e}
The option @option{-e} has historically been underspecified, with enough
ambiguities to cause numerous differences across various shell
-implementations. Perhaps the best reference is
address@hidden://www.opengroup.org/@/austin/@/mailarchives/@/ag-review/@/msg03507.html,
-this link}, recommending a change to Posix 2008 to match @command{ksh88}
-behavior. Note that mixing @code{set -e} and shell functions is asking
-for surprises:
+implementations; see for example
address@hidden://www.in-ulm.de/@/~mascheck/@/various/@/set-e/, this overview},
+or @uref{http://www.austingroupbugs.net/@/view.php?id=52, this link},
+documenting a change to Posix 2008 to match @command{ksh88} behavior.
+Note that mixing @code{set -e} and shell functions is asking for surprises:
@example
set -e