wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | * libwget/ssl_gnutls.c (verify_certificate_callback): Warn a


From: Romain Geissler (@Romain-Geissler-1A)
Subject: Re: wget2 | * libwget/ssl_gnutls.c (verify_certificate_callback): Warn about OCSP privacy leak (!549)
Date: Sun, 19 May 2024 14:04:22 +0000



Romain Geissler commented: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/549#note_1911711655


The changes around the addition of `skip_server_cert_check` and the new warning 
logic + the wording is fine for me.

The other change like the move from the condition `it >= nvalid` to `it != 0` 
honestly this is to be reviewed by someone who knows this part of the code 
better than me ;)

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/549#note_1911711655
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]