Re: wget2 | Several OCSP improvements (!513)

[@rockdaboot]

Tim Rühsen commented:


HTTPS checks are failing, reproducible with
```
make='make -j$(nproc)'
./configure --with-ssl=openssl
make clean
make
make check-valgrind
```

e.g. from `tests/test-ocsp-server.log`:
```
==73655== Invalid read of size 1
==73655==    at 0x4849794: strlen (in 
/usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==73655==    by 0x48672C4: copy_string (buffer_printf.c:65)
==73655==    by 0x48677D3: wget_buffer_vprintf_append (buffer_printf.c:455)
==73655==    by 0x4867963: wget_buffer_vprintf (buffer_printf.c:522)
==73655==    by 0x48768D2: logger_vprintf_func (logger.c:46)
==73655==    by 0x487681B: wget_debug_printf (log.c:105)
==73655==    by 0x488151D: ssl_set_alpn_selected_protocol (ssl_openssl.c:1539)
==73655==    by 0x4881E5D: wget_ssl_open (ssl_openssl.c:1772)
==73655==    by 0x4878358: wget_tcp_connect (net.c:761)
==73655==    by 0x4871DD8: wget_http_open (http.c:657)
==73655==    by 0x119370: try_connection (wget.c:1555)
==73655==    by 0x1195BA: establish_connection (wget.c:1626)
==73655==  Address 0x6b1e5d8 is 0 bytes after a block of size 8 alloc'd
==73655==    at 0x48437B4: malloc (in 
/usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==73655==    by 0x4DC46B0: ??? (in /usr/lib/x86_64-linux-gnu/libssl.so.3)
==73655==    by 0x4DC03DF: ??? (in /usr/lib/x86_64-linux-gnu/libssl.so.3)
==73655==    by 0x4DD27CE: ??? (in /usr/lib/x86_64-linux-gnu/libssl.so.3)
==73655==    by 0x4DCADB1: ??? (in /usr/lib/x86_64-linux-gnu/libssl.so.3)
==73655==    by 0x4881D8D: wget_ssl_open (ssl_openssl.c:1714)
==73655==    by 0x4878358: wget_tcp_connect (net.c:761)
==73655==    by 0x4871DD8: wget_http_open (http.c:657)
==73655==    by 0x119370: try_connection (wget.c:1555)
==73655==    by 0x1195BA: establish_connection (wget.c:1626)
==73655==    by 0x121FE8: downloader_thread (wget.c:2311)
==73655==    by 0x4A7B849: start_thread (pthread_create.c:442)
```

Not sure if this is due to your changes, but it stems from openssl code.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/513#note_1121304564
You're receiving this email because of your account on gitlab.com.