Re: wget2 | Several OCSP improvements (!513)

[@rockdaboot]

Tim Rühsen started a new discussion on libwget/ssl_openssl.c: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/513#note_1113464956

> +{
> +     char *fingerprint = NULL;
> +     const struct ocsp_stapled_response *ocsp_stapled_resp;
> +
> +     /* Check if there's already a stapled OCSP response in our cache */
> +     ocsp_stapled_resp = ocsp_stapled_response_get(cert, issuer, 
> ocsp_stapled_cache);
> +     if (ocsp_stapled_resp &&
> +                     (ocsp_stapled_resp->status == V_OCSP_CERTSTATUS_GOOD || 
> ocsp_stapled_resp->status == V_OCSP_CERTSTATUS_REVOKED)) {
> +             *revoked = (ocsp_stapled_resp->status == 
> V_OCSP_CERTSTATUS_REVOKED);
> +             *cache_origin = "stapled";
> +             return 1;
> +     }
> +
> +     if (ocsp_cert_cache) {
> +             /* Compute cert fingerprint */
> +             fingerprint = compute_cert_fingerprint(cert);

Please move the `fingerprint` declaration into this block. And the 
`xfree(fingerprint)` can then be moved into the block as well.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/513#note_1113464956
You're receiving this email because of your account on gitlab.com.