wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | Draft: Small fixes (!505)


From: @rockdaboot
Subject: Re: wget2 | Draft: Small fixes (!505)
Date: Mon, 25 Apr 2022 19:05:33 +0000



Tim Rühsen commented on a discussion on src/wget.c: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/505#note_923353864

>       signal(SIGINT, nop);
>  #else
>       // need to set some signals
> -     struct sigaction sig_action;
> -     memset(&sig_action, 0, sizeof(sig_action));
> +     struct sigaction sig_action = {0};

I just wonder when this will bite back... the explicit memset was there for a 
reason (slap me for not documenting). Maybe it was valgrind or a sanitizer or a 
static analyzer or ...
But yeah, let's change it to C99 and then see (also the other sigaction places 
please).

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/505#note_923353864
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]