Re: wget2 | Small fixes (!505)

[@rockdaboot]

Tim Rühsen commented on a discussion on libwget/cookie.c: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/505#note_922054704

>  wget_cookie_db *wget_cookie_db_init(wget_cookie_db *cookie_db)
>  {
>       if (!cookie_db) {
> -             cookie_db = wget_malloc(sizeof(wget_cookie_db));
> +             cookie_db = wget_calloc(1, sizeof(wget_cookie_db));
>               if (!cookie_db)
>                       return NULL;
>       }
>  
> -     memset(cookie_db, 0, sizeof(*cookie_db));

This code change is buggy, as the memset zeros the cookie_db even if it already 
exists. That is the reason why we don't use calloc here.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/505#note_922054704
You're receiving this email because of your account on gitlab.com.