Re: wget2 | */Makefile.am: Add INTL_MACOSX_LIBS to LIBADDs (!504)

[@rockdaboot]

Tim Rühsen commented:


Thanks for the patch ! (Did you also run `make check`, possibly with 
libmicrohttpd installed ?)

I think the commits a84c8d0686bb409b7463d96cac51fe9317dbe0c9 and 
040f6cc3784a40a0343ecfaf1cd77ef848acf6ec introduced this issue. Without the 
patch to libtool, `-Wl,--no-whole-archive` has no effect and so `gnulib.la` is 
completely added to the libraries. And that means we have to add 
`@INTL_MACOSX_LIBS@` to *_LIBADD - but likely also every entry from
```
$(GETADDRINFO_LIB) $(GETHOSTNAME_LIB) $(HOSTENT_LIB) $(INET_NTOP_LIB) 
$(INET_PTON_LIB) \
 $(LIBMULTITHREAD) $(LIBSOCKET) $(LIBTHREAD) $(LIB_CLOCK_GETTIME) $(LIB_CRYPTO) 
$(LIB_GETLOGIN) \
 $(LIB_HARD_LOCALE) $(LIB_MBRTOWC) $(LIB_NANOSLEEP) $(LIB_POLL) 
$(LIB_POSIX_SPAWN) $(LIB_PTHREAD_SIGMASK) \
 $(LIB_SELECT) $(LIB_SETLOCALE) $(LIB_SETLOCALE_NULL) $(LTLIBICONV) 
$(LTLIBINTL) $(SERVENT_LIB)
```

On Linux, these variables are empty. But on other OSes, they may not.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/504#note_863898511
You're receiving this email because of your account on gitlab.com.