Re: wget2 | build: Fix the build with slibtool (!498)

[@rockdaboot]

Tim Rühsen commented:


My current issue is that I am not into the details any more but would like to 
understand what is going on here. But I have only 20mins per week currently for 
this.

On Debian (unstable) something is not as expected (with and without your 
patch), as pthread gets linked when not needed
```
libtool: link: gcc -shared  -fPIC -DPIC  .libs/libwget_alloc_la-xalloc.o   
../lib/.libs/libgnu.a    -g -ggdb3 -Og   -pthread -Wl,-soname 
-Wl,libwget_alloc.so.1 -o .libs/libwget_alloc.so.1.0.0

$ ldd libwget/.libs/libwget_alloc.so.1.0.0
        linux-vdso.so.1 (0x00007ffef858e000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 
(0x00007f53eb2f6000) <<--superfluous
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f53eb131000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f53eb361000)
```
The idea originally was to *not* link in unneeded libraries.

BTW, all the CI runners fail for this PR, `make syntax-check` says
```
m4/ax_pthread.m4:188:#            if !defined(_OPEN_THREADS) && 
!defined(_UNIX03_THREADS)
m4/ax_pthread.m4:218:#            if defined(__clang__) && defined(__llvm__)
maint.mk: found useless parentheses in cpp directive
make: *** [maint.mk:847: sc_useless_cpp_parens] Error 1
```

So I'd really appreciate to get rid of the libtool patch, especially as it 
currently seems to be out-of-order.

Currently, this needs to be tackled:
- get rid of the pthread library (when not needed)
- fix the syntax-check

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/498#note_693145259
You're receiving this email because of your account on gitlab.com.