wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | Abandon use of gcc attribute 'nonnull' from API (#200)


From: jeffrey marius (@getjff)
Subject: Re: wget2 | Abandon use of gcc attribute 'nonnull' from API (#200)
Date: Sun, 25 Jul 2021 14:02:10 +0000



jeffrey marius commented:


Yes, WGET_GCC_NONNULL is used in our code extensively. I agree with your point 
that we should do NULL check instead of using this attribute. And I agree this 
is not a Junior Task but I am software engineer by profession, I am just new to 
Open Source Contributions :smile: . I think I can take up this task and make 
sure we do NULL checks and return error in all places of usage.

Also, yes we can have WGET_GCC_NONULL for scan-build to verify our code. I will 
introduce that as well.

If you are fine I will start working on this task.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/issues/200#note_634819207
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]