Re: wget | Long pathnames patch (!24)

[@rockdaboot]

Tim Rühsen started a new discussion on src/url.c: 
https://gitlab.com/gnuwget/wget/-/merge_requests/24#note_599794037

>       string length.  Each quoted char introduces two additional
>       characters in the string, hence 2*quoted.  */
>    outlen = (e - b) + (2 * quoted);
> +# ifdef WINDOWS
> +  max_length = MAX_PATH;
> +# else
> +  max_length = get_max_length(dest->base, dest->tail, _PC_NAME_MAX);
> +# endif
> +  max_length -= CHOMP_BUFFER;
> +  if (max_length > 0 && outlen > max_length)
> +    {
> +      logprintf (LOG_NOTQUIET, "The destination name is too long (%d), 
> reducing to %ld\n", outlen, max_length);

Hi @jmoellers The MR looks good to me :-)

Just two little cosmetic things
- please use %d here (%ld introduces a warning)
- you forgot the remove an unused variable:
```
url.c: In function 'url_file_name':
url.c:1734:10: warning: unused variable 'max_length' [-Wunused-variable]
 1734 |   size_t max_length;
      |          ^~~~~~~~~~
```

If possible, don't open a new MR. Just amend your commit (make your changes and 
`git commit --amend -a`) and the force push it. This automatically updates this 
MR, the CI is run again and I get a notification. TY !

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget/-/merge_requests/24#note_599794037
You're receiving this email because of your account on gitlab.com.