wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | Fixed data corruption bugs in transfer encoding chunked code


From: Tim Rühsen
Subject: Re: wget2 | Fixed data corruption bugs in transfer encoding chunked code (!480)
Date: Sun, 24 Jan 2021 13:03:22 +0000



Tim Rühsen commented on a discussion on libwget/http.c: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/480#note_492577464

>       }
>       if (!nread) goto cleanup;
>  
> +     if (!p) goto cleanup;

Yes, I was wrong. p can be NULL when the wget_tcp_read() returns < 0 (but not 
when the loop comes to `break;`).

I'll add the check as an extra commit in your name, as I just did for the 
nread-nbytes check.
I favor to do so in order to split separate issues (which they are).

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/480#note_492577464
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]