wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | OpenSSL: OCSP support (!468)


From: Tim Rühsen
Subject: Re: wget2 | OpenSSL: OCSP support (!468)
Date: Sat, 04 Apr 2020 21:16:01 +0000



Tim Rühsen commented:


Not sure why our CI doesn't catch it, but there are these warnings (look like 
missing cosmetics):
```
ssl_openssl.c: In function 'send_ocsp_request':
ssl_openssl.c:540:9: warning: unused parameter 'subject_cert' 
[-Wunused-parameter]
  540 |   X509 *subject_cert, OCSP_CERTID *certid,
      |   ~~~~~~^~~~~~~~~~~~
ssl_openssl.c: In function 'get_printable_ocsp_reason_desc':
ssl_openssl.c:596:2: warning: switch missing default case [-Wswitch-default]
  596 |  switch (reason) {
      |  ^~~~~~
ssl_openssl.c: In function 'print_ocsp_cert_status':
ssl_openssl.c:652:31: warning: unused parameter 'revtime' [-Wunused-parameter]
  652 |   const ASN1_GENERALIZEDTIME *revtime)
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
ssl_openssl.c: In function 'check_ocsp_response':
ssl_openssl.c:690:16: warning: unused parameter 'certid' [-Wunused-parameter]
  690 |   OCSP_CERTID *certid,
      |   ~~~~~~~~~~~~~^~~~~~
In file included from ../lib/gettext.h:26,
                 from private.h:38,
                 from ssl_openssl.c:57:
ssl_openssl.c: In function 'check_cert_chain_for_ocsp':
ssl_openssl.c:906:19: warning: format '%d' expects argument of type 'int', but 
argument 2 has type 'unsigned int' [-Wformat=]
  906 |    error_printf(_("Could not compute certificate fingerprint for cert 
%d\n"), i);
      |                   
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ssl_openssl.c:906:17: note: in expansion of macro '_'
  906 |    error_printf(_("Could not compute certificate fingerprint for cert 
%d\n"), i);
      |                 ^
ssl_openssl.c:906:72: note: format string is defined here
  906 |    error_printf(_("Could not compute certificate fingerprint for cert 
%d\n"), i);
      |                                                                       ~^
      |                                                                        |
      |                                                                        
int
      |                                                                       %d
ssl_openssl.c:915:33: warning: format '%d' expects argument of type 'int', but 
argument 2 has type 'unsigned int' [-Wformat=]
  915 |      debug_printf("Certificate %d has been revoked (cached 
response)\n", i);
      |                                ~^                                       
 ~
      |                                 |                                       
 |
      |                                 int                                     
 unsigned int
      |                                %d
ssl_openssl.c:918:33: warning: format '%d' expects argument of type 'int', but 
argument 2 has type 'unsigned int' [-Wformat=]
  918 |      debug_printf("Certificate %d is valid (cached response)\n", i);
      |                                ~^                                ~
      |                                 |                                |
      |                                 int                              
unsigned int
      |                                %d
In file included from ../lib/gettext.h:26,
                 from private.h:38,
                 from ssl_openssl.c:57:
ssl_openssl.c:930:19: warning: format '%d' expects argument of type 'int', but 
argument 2 has type 'unsigned int' [-Wformat=]
  930 |     info_printf(_("OCSP URI not given and not found in certificate. 
Skipping OCSP check for cert %d.\n"),
      |                   
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ssl_openssl.c:930:17: note: in expansion of macro '_'
  930 |     info_printf(_("OCSP URI not given and not found in certificate. 
Skipping OCSP check for cert %d.\n"),
      |                 ^
ssl_openssl.c:930:99: note: format string is defined here
  930 |     info_printf(_("OCSP URI not given and not found in certificate. 
Skipping OCSP check for cert %d.\n"),
      |                                                                         
                         ~^
      |                                                                         
                          |
      |                                                                         
                          int
      |                                                                         
                         %d
ssl_openssl.c: In function 'get_tls_version':
ssl_openssl.c:1303:2: warning: switch missing default case [-Wswitch-default]
 1303 |  switch (version) {
      |  ^~~~~~
ssl_openssl.c: In function 'wget_ssl_open':
ssl_openssl.c:1446:6: warning: 'error' may be used uninitialized in this 
function [-Wmaybe-uninitialized]
 1446 |   if (error == SSL_ERROR_SSL) {
      |      ^
```

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/468#note_317689309
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]