wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Wget-dev] wget2 | Added options --method, --body-data, --body-file (!45


From: Archit Pandey
Subject: [Wget-dev] wget2 | Added options --method, --body-data, --body-file (!455)
Date: Thu, 24 Oct 2019 18:56:17 +0000


Archit Pandey created a merge request: 
https://gitlab.com/gnuwget/wget2/merge_requests/455

Project:Branches: archit-p/wget2:add-option-method to gnuwget/wget2:master
Author:    Archit Pandey



This merge request closes https://gitlab.com/gnuwget/wget2/issues/437
### Design
* The variables `method`, `body_data` and `body_file` were added as _strings_ 
to `struct config`. 
* `config.method` is checked before checking `job->head_first`, 
`config.post_data` or `config.post_file` to decide the method for requests.
* Design for `--body-data` and `--body-file` was borrowed from that for 
`--post-data` and `--post-file`.

### Possible Flaws
* There is currently no check in the code to ensure only one of `--post-data`, 
`--post-file`, `--body-data` or `--body-file` are used.
* There is no test in the test-suite for `--post-data`, `--post-file`, 
`--body-data`, `--body-file` and `--method`.

### Approver's checklist:

* [ ] The author has submitted the FSF Copyright Assignment and is listed in 
AUTHORS
* [ ] There is a test suite reasonably covering new functionality or 
modifications
* [ ] Function naming, parameters, return values, types, etc., are consistent 
with existing code
* [ ] This feature/change has adequate documentation added (if appropriate)
* [ ] No obvious mistakes / misspelling in the code

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/merge_requests/455
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]