wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Wget-dev] wget2 | WIP: Implemented limit-rate feature (!420)


From: Tim Rühsen
Subject: Re: [Wget-dev] wget2 | WIP: Implemented limit-rate feature (!420)
Date: Mon, 22 Apr 2019 09:26:56 +0000



Check that line 3396 (I think it's `ctx->limit_debt_bytes += read_bytes;`. One 
of the variables has
```
$ printf '%X\n' 18446744073709551104
FFFFFFFFFFFFFE00
```
Adding 102400 to it overflows it. `ctx->limit_debt_bytes` is treated as an 
unsigned here because `read_bytes` is an unsigned.

Try `ctx->limit_debt_bytes += (long long) read_bytes;` to keep the arithmetic 
signed.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/merge_requests/420#note_162856663
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]